Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag feature releases? #113

Closed
chrmarti opened this issue Aug 23, 2022 · 5 comments
Closed

Tag feature releases? #113

chrmarti opened this issue Aug 23, 2022 · 5 comments
Assignees

Comments

@chrmarti
Copy link

@joshspicer @samruddhikhandale Should feature releases be tagged in the Git repo? I don't see how I would currently navigate from an OCI artifact to the commit it was created from. We usually use tags for that. What do you think?

@joshspicer
Copy link
Member

joshspicer commented Aug 23, 2022

We're currently releasing each feature independently by bumping the version in the feature's devcontainer-feature.json.

We could do something like v0.0.5-ruby when creating the release for a feature (in this example, ruby). Would that make sense?

@chrmarti
Copy link
Author

Make it ruby-v0.0.5 to avoid collision with semver's pre-release/build labels. 👍

@joshspicer
Copy link
Member

@samruddhikhandale , this could be introduced in addition to the versioning github action we discussed

@joshspicer
Copy link
Member

I introduced this change to the CLI in order to hand GitHub action the appropriate tags that were pushed

devcontainers/cli#305

@joshspicer
Copy link
Member

This has been complete and rolled out for some time. Tagging is done by the github action we publish (devcontainers/action)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants