Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Oryx tool needs to be built with .NET 7 #760

Closed
samruddhikhandale opened this issue Nov 18, 2023 · 3 comments
Closed

[Bug] Oryx tool needs to be built with .NET 7 #760

samruddhikhandale opened this issue Nov 18, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@samruddhikhandale
Copy link
Member

samruddhikhandale commented Nov 18, 2023 •
edited
Loading

From devcontainers/images#855 (comment)
Blocks devcontainers/images#855

Oryx tool needs to be built with .NET 7, however, looking at https://github.com/devcontainers/images/actions/runs/6895550673/job/18760553721?pr=855#step:3:18052, it's getting built with .NET 8. This is definitely a bug in the oryx Feature which needs to be fixed to unblock this PR.
@samruddhikhandale samruddhikhandale added the bug Something isn't working label Nov 18, 2023
@samruddhikhandale samruddhikhandale self-assigned this Nov 21, 2023
@samruddhikhandale samruddhikhandale mentioned this issue Nov 28, 2023
Merged
4 tasks
@seesharprun seesharprun mentioned this issue Nov 30, 2023
Closed
@seesharprun
Copy link

I'm working on a PR (microsoft/Oryx#2272) to see if we can get this limitation removed entirely.

The packages referenced in the Directory.Build.props file are causing the build error even if you have .NET 7 installed. The reason is because .NET 8 ships with newer versions of those packages and the build error is intentional to push people to upgrade and not leave critical packages locked to older versions.

@samruddhikhandale samruddhikhandale removed their assignment Nov 30, 2023
@VincentDondain VincentDondain changed the title [Oryx bug] tool needs to be built with .NET 7 [Bug] Oryx tool needs to be built with .NET 7 Dec 5, 2023
@seesharprun
Copy link

I think we can consider this bug solved now, correct?

@samruddhikhandale
Copy link
Member Author

Yep, oryx is now built with .NET 8. Thanks @seesharprun for microsoft/Oryx#2272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seesharprun @samruddhikhandale