Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert dependency updates made between 4.0.0 and 4.1.0 #83

Closed
buffcode opened this issue Jul 11, 2022 · 5 comments
Closed

Revert dependency updates made between 4.0.0 and 4.1.0 #83

buffcode opened this issue Jul 11, 2022 · 5 comments

Comments

@buffcode
Copy link

electron-builder currently won't upgrade app-builder, because the compression modifiers somehow break: electron-userland/electron-builder#6684

As such electron-builder is stuck to 4.0.0 and is unable to incorporate other bugfixes such as #63 (see electron-userland/electron-builder#6710 (comment)).

I propose to revert the dependency changes inflicting problems with AppImages until this can be resolved, in order to unlock the other patches downstream.

Thanks for your consideration!

@buffcode buffcode changed the title Revert dependency update made between 4.0.0 and 4.1.0 Revert dependency updates made between 4.0.0 and 4.1.0 Jul 11, 2022
@mmaietta
Copy link
Collaborator

CC @develar could you please take a look at this? It'd be great to update electron-builder to latest app-builder but the current release breaks AppImages

@beyondkmp
Copy link
Contributor

beyondkmp commented Feb 1, 2023

@mmaietta I think the root cause is that mksquashfs in appimage-13 doesn't support gzip.
image
image

In https://github.com/electron-userland/electron-builder-binaries/blob/master/zstd-linux.sh:
Why do you set GZIP_SUPPORT to 0 and set COMP_DEFAULT to zstd?
If we don't set these special params, I think it will works well.

@develar
Copy link
Owner

develar commented Sep 12, 2023

I published 4.2.0, @mmaietta please update the version in electron-builder.

@mmaietta
Copy link
Collaborator

mmaietta commented Sep 12, 2023

@develar I've attempted to update the dependency in electron-builder but mac and linux CI tests are failing. Can you please take a look?
EACCES error code is being thrown with the 4.2.0 update

MacOS

> @electron-builder/monorepo@ ci:test /Users/runner/work/electron-builder/electron-builder
> node ./test/out/helpers/runTests.js

Error: spawn /Users/runner/work/electron-builder/electron-builder/node_modules/.pnpm/app-builder-bin@4.2.0/node_modules/app-builder-bin/mac/app-builder_amd64 EACCES

Linux:

Error: spawn /project/node_modules/.pnpm/app-builder-bin@4.2.0/node_modules/app-builder-bin/linux/x64/app-builder EACCES

PR electron-userland/electron-builder#7774

@ramiel
Copy link

ramiel commented Sep 24, 2023

I need this modification in order to have a working electron-builder. Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants