Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set logo max-width #127

Open
pvalena opened this issue Nov 5, 2021 · 2 comments
Open

Set logo max-width #127

pvalena opened this issue Nov 5, 2021 · 2 comments
Labels

Comments

@pvalena
Copy link
Contributor

pvalena commented Nov 5, 2021

E.g.
https://developer.stg.fedoraproject.org/tech.html

The Redis logo f.e..

@pvalena pvalena added the bug label Nov 5, 2021
@jackorp
Copy link
Contributor

jackorp commented Nov 5, 2021

Max width sounds like a good idea it would provide consistency in the logos.

However, note that the Redis logo has writing making the whole text shift more to the right,
Having max-width would probably result in the logo getting much smaller... (AFAICT it's 300x100 -- 3:1 ratio of width to height, if it will get scaled it will look overall smaller than it should IMHO)

@dknight
Copy link
Contributor

dknight commented Nov 6, 2021

Agree with @jackorp
Some logos have different dimensions and some of them have too much empty space inside image file, I put max-width: 100px some logos looked really bad and there is problem with alignment as well. Only solutions to "redraw" all logos in one style in graphical editor. max-width is not a solution at current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants