From 34884116e21408305b337a9f6267f6c2ddc9e72d Mon Sep 17 00:00:00 2001
From: Ward Peeters <ward@coding-tech.com>
Date: Mon, 17 Aug 2020 08:52:22 +0200
Subject: [PATCH] fix: disable node-builtin warnings (#700)

---
 .changeset/tame-singers-grin.md               |  5 +++
 package.json                                  |  1 +
 src/index.js                                  |  7 ++++
 test/__snapshots__/index.test.js.snap         | 41 +++++++++++++++++++
 .../basic-node-internals/package.json         |  6 +++
 .../basic-node-internals/src/index.js         | 13 ++++++
 6 files changed, 73 insertions(+)
 create mode 100644 .changeset/tame-singers-grin.md
 create mode 100644 test/fixtures/basic-node-internals/package.json
 create mode 100644 test/fixtures/basic-node-internals/src/index.js

diff --git a/.changeset/tame-singers-grin.md b/.changeset/tame-singers-grin.md
new file mode 100644
index 00000000..3ab2c1d2
--- /dev/null
+++ b/.changeset/tame-singers-grin.md
@@ -0,0 +1,5 @@
+---
+'microbundle': patch
+---
+
+Disable warnings for node's builtin-modules when using node as a target environment.
diff --git a/package.json b/package.json
index b541e3f7..d4ab4235 100644
--- a/package.json
+++ b/package.json
@@ -93,6 +93,7 @@
     "babel-plugin-transform-async-to-promises": "^0.8.15",
     "babel-plugin-transform-replace-expressions": "^0.2.0",
     "brotli-size": "^4.0.0",
+    "builtin-modules": "^3.1.0",
     "camelcase": "^5.3.1",
     "cssnano": "^4.1.10",
     "es6-promisify": "^6.1.1",
diff --git a/src/index.js b/src/index.js
index 2e41cea3..423fc2de 100644
--- a/src/index.js
+++ b/src/index.js
@@ -8,6 +8,7 @@ import glob from 'tiny-glob/sync';
 import autoprefixer from 'autoprefixer';
 import cssnano from 'cssnano';
 import { rollup, watch } from 'rollup';
+import builtinModules from 'builtin-modules';
 import commonjs from '@rollup/plugin-commonjs';
 import babel from '@rollup/plugin-babel';
 import customBabel from './lib/babel-custom';
@@ -306,6 +307,12 @@ function createConfig(options, entry, format, writeMeta) {
 	const moduleAliases = options.alias ? parseAliasArgument(options.alias) : [];
 	const aliasIds = moduleAliases.map(alias => alias.find);
 
+	// We want to silence rollup warnings for node builtins as we rollup-node-resolve threats them as externals anyway
+	// @see https://github.com/rollup/plugins/tree/master/packages/node-resolve/#resolving-built-ins-like-fs
+	if (options.target === 'node') {
+		external = external.concat(builtinModules);
+	}
+
 	const peerDeps = Object.keys(pkg.peerDependencies || {});
 	if (options.external === 'none') {
 		// bundle everything (external=[])
diff --git a/test/__snapshots__/index.test.js.snap b/test/__snapshots__/index.test.js.snap
index ff46d384..6867eee8 100644
--- a/test/__snapshots__/index.test.js.snap
+++ b/test/__snapshots__/index.test.js.snap
@@ -859,6 +859,47 @@ exports[`fixtures build basic-no-pkg-main with microbundle 3`] = `
 "
 `;
 
+exports[`fixtures build basic-node-internals with microbundle 1`] = `
+"Used script: microbundle --target=node -f cjs
+
+Directory tree:
+
+basic-node-internals
+  dist
+    basic-node-internals.js
+    basic-node-internals.js.map
+  package.json
+  src
+    index.js
+
+
+Build \\"basicNodeInternals\\" to dist:
+191 B: basic-node-internals.js.gz
+149 B: basic-node-internals.js.br"
+`;
+
+exports[`fixtures build basic-node-internals with microbundle 2`] = `2`;
+
+exports[`fixtures build basic-node-internals with microbundle 3`] = `
+"var child_process = require('child_process');
+
+function runCommand(cmd) {
+  return new Promise((resolve, reject) => {
+    child_process.exec(cmd, (error, stdout, stderr) => {
+      if (error) {
+        reject(error);
+      }
+
+      resolve(stdout || stderr);
+    });
+  });
+}
+
+exports.runCommand = runCommand;
+//# sourceMappingURL=basic-node-internals.js.map
+"
+`;
+
 exports[`fixtures build basic-ts with microbundle 1`] = `
 "Used script: microbundle
 
diff --git a/test/fixtures/basic-node-internals/package.json b/test/fixtures/basic-node-internals/package.json
new file mode 100644
index 00000000..8f77b4cc
--- /dev/null
+++ b/test/fixtures/basic-node-internals/package.json
@@ -0,0 +1,6 @@
+{
+  "name": "basic-node-internals",
+  "scripts": {
+    "build": "microbundle --target=node -f cjs"
+  }
+}
diff --git a/test/fixtures/basic-node-internals/src/index.js b/test/fixtures/basic-node-internals/src/index.js
new file mode 100644
index 00000000..943e20f2
--- /dev/null
+++ b/test/fixtures/basic-node-internals/src/index.js
@@ -0,0 +1,13 @@
+import { exec } from 'child_process';
+
+export function runCommand(cmd) {
+	return new Promise((resolve, reject) => {
+		exec(cmd, (error, stdout, stderr) => {
+			if (error) {
+				reject(error);
+			}
+
+			resolve(stdout || stderr);
+		});
+	});
+}