fix: support hoisted packages #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FezVrasta
pushed a commit
to quid/refraction
that referenced
this pull request
Dec 11, 2018
this new fork includes: - developit/microbundle#271 - developit/microbundle#268 - developit/microbundle#265 these changes are planned to be merged upstream anytime soon
Andarist
reviewed
Dec 11, 2018
FezVrasta
force-pushed
the
fix/hoisted-packages
branch
from
1b58e88 to
058b2b9
Compare
|
Have you tested that this works? |
|
@ForsakenHarmony yes that's how I discovered I needed it :-) |
Andarist
approved these changes
Dec 11, 2018
marvinhagemeister
approved these changes
Dec 11, 2018
|
As long as it works on Windows 👀 |
|
Unfortunately I don't have any Windows machine to test 😞 |
|
@ForsakenHarmony it should work, because its normalized under the hood https://github.com/rollup/rollup-pluginutils/blob/fe8b70a981114becb856dfbc0f1099b6a255ce17/src/createFilter.js#L15 |
FezVrasta
pushed a commit
to quid/refraction
that referenced
this pull request
Jan 31, 2019
this new fork includes: - developit/microbundle#271 - developit/microbundle#268 - developit/microbundle#265 these changes are planned to be merged upstream anytime soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix #270