Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type declarations missing in npm package #89

Closed
florianmrz opened this issue Aug 4, 2020 · 2 comments
Closed

Type declarations missing in npm package #89

florianmrz opened this issue Aug 4, 2020 · 2 comments

Comments

@florianmrz
Copy link

When installing from npm (Version 1.2.2), I end up without the type declarations.
See https://unpkg.com/browse/snarkdown@1.2.2/ for a list of files in the package.

Are these being omitted when publishing to npm? Is the version on npm simply outdated?

@jonathonherbert
Copy link

jonathonherbert commented Aug 19, 2020

I'm also having the same issue.

Edit: it looks like the type definitions (#73) were merged after the latest release, as mentioned in a thread comment in that PR. All that is required is a new release.

That'd be really handy, this is a lovely nugget of a library and it's a shame to have to manually add types 😄

@developit
Copy link
Owner

Fixed in #86. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants