-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex tests #33
Comments
What regex tests? |
For |
I can't get what you're talking about. Where's that? What regexes here? |
28 lines. |
Good moin'. Next time when open an issue describe what you mean as much as possible in your title and first post. |
Wonder that you have not understand. |
@dimpiax I had a bunch of tests I was running in a REPL when writing the header parsing, I should have ported them to unit tests but didn't. Happy to merge a PR that does it. Easiest way will be to mock out |
@developit considering the changes to the headers regex in #92 I'm not sure of the best way to test this anymore. The headers regex is now extremely simple and we're leveraging the internals of XMLHttpRequest with |
Need to add regex tests.
Tested expression on validators, it gives strange results.
@developit could you provide expectations?
The text was updated successfully, but these errors were encountered: