Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

titiler.core requires fastapi < 0.66 #366

Closed
mkaminsky opened this issue Sep 2, 2021 · 3 comments · Fixed by #368
Closed

titiler.core requires fastapi < 0.66 #366

mkaminsky opened this issue Sep 2, 2021 · 3 comments · Fixed by #368
Labels
bug Something isn't working

Comments

@mkaminsky
Copy link

Problem description

I've been playing around with titiler, and it seems really nice—thanks! I would like to experiment using titiler.core to add /cog endpoints to my own FastAPI-based project. Currently, titiler is restricted to versions of FastAPI < 0.66 (the latest version is 0.68.1). Is there something about the more recent releases that is incompatible, or is it safe to remove that restriction?

Output

$ poetry add titiler.core
Using version ^0.3.8 for titiler.core

Updating dependencies
Resolving dependencies... (3.8s)

  SolverProblemError

  Because titiler.core (0.3.8) depends on fastapi (>=0.65,<0.66)
   and no versions of titiler.core match >0.3.8,<0.4.0, titiler.core (>=0.3.8,<0.4.0) requires fastapi (>=0.65,<0.66).
  So, because project depends on both fastapi (^0.68.0) and titiler.core (^0.3.8), version solving failed.

Expected Output

Adding package succeeds.

Environment Information

Linux, Python 3.9, poetry

@mkaminsky mkaminsky added the bug Something isn't working label Sep 2, 2021
@vincentsarago
Copy link
Member

Is there something about the more recent releases that is incompatible, or is it safe to remove that restriction?

Yes, see:

So while openapi/fastapi won't support Tuple with defined length we won't be able to update fastapi>0.67

FYI pinning FastAPI is recommended by fastapi docs https://fastapi.tiangolo.com/deployment/versions/#pin-your-fastapi-version

@vincentsarago
Copy link
Member

Note: I think it will be ok to update the version to >=0.65,<0.68 to enable stac-fastapi and titiler

@mkaminsky
Copy link
Author

Thanks for the quick reply. Makes sense--I do recall seeing that OpenAPI Tuple length issue at some point.

Pinning to an earlier version of FastAPI seems to work smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants