Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes and refactor #3

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Minor changes and refactor #3

merged 1 commit into from
Dec 12, 2020

Conversation

victor-iyi
Copy link

@victor-iyi victor-iyi commented Dec 12, 2020

Mostly containing style changes & refactor; including OpenSSL build requirement for Fedora and Ubuntu in README.md.

Some changes include:

  • Added MythraResult<T> type, rather than passing Result<T, Box<dyn std::errror::Error>> around.
  • Moved src/engine.rs to src/engine/mod.rs.
  • Markdown rule updates for README.md.
  • Bump version number & dependencies upgrade.

Roadmap:

  • Implement engine traits. e.g impl FreeMP3Cloud for EngineTrait { ... }.
  • To be moved from type.rs to engine/mod.rs.
  • parse_single_music has return type Option while EngineTrait has MythraResult.
  • Triat definition isn't pub async.
  • Dedicated *music.rs mod including Music structs/traits implementations.
  • Documentation with rustdoc.
  • Match engine as enums on src/api.rs:18.
  • Create *bulid.rs to handle OpenSSL versions and platforms.
  • Simplification of utils.rs.
  • Engine already matched in src/api.rs:search, it shouldn't be repeated in src/engine/mod.rs:search_all.
  • download.rs:download_from_url should return a Result type indicating if download failed or succeeded.
  • More error support required in *error.rs.

@deven96 deven96 merged commit 26898cf into Go-phie:master Dec 12, 2020
MeNsaaH pushed a commit that referenced this pull request Apr 21, 2023
Minor changes and refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants