Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this module still maintained? #182

Closed
ivpusic opened this issue Jan 17, 2017 · 13 comments
Closed

is this module still maintained? #182

ivpusic opened this issue Jan 17, 2017 · 13 comments

Comments

@ivpusic
Copy link
Contributor

ivpusic commented Jan 17, 2017

I am using this module in my projects. Last few months there are no new commits into the master branch. Does this mean you have no plans/time/whatever to continue to support it? This is important to know for me and others if we should wait or fork library?

Thanks

@aakashsigdel
Copy link

I don't think this is the case. There are PRs from more than months old that have not been merged.

@ivpusic
Copy link
Contributor Author

ivpusic commented Jan 17, 2017

@devfd any thoughts on this?

@dantman
Copy link

dantman commented Jan 18, 2017

Not having someone to merge commits and publish to npm is going to be a problem. This package already needs a new release that's compatible with RN 0.40.

@mkdotcom
Copy link

and android signin doesn't work since some time now...

@joonhocho
Copy link

@ivpusic @aakashsigdel @dantman @mkdotcom
This repo did not work for me, so I created one myself.
I am currently using it for my project.
https://github.com/joonhocho/react-native-google-sign-in

@dantman
Copy link

dantman commented Mar 3, 2017

@ivpusic @aakashsigdel @mrKlar @Freddy03h @maxh @ujwal-setlur @Kerumen @dannycochran
@devfd appears to have disappeared, is there anyone interested in taking over maintenance of the project?

@Kerumen
Copy link
Collaborator

Kerumen commented Mar 3, 2017

I already proposed myself here.

@aakashsigdel
Copy link

aakashsigdel commented Mar 3, 2017 via email

@devfd
Copy link
Contributor

devfd commented Mar 3, 2017

sorry guys I took some time off. this plugin is really hard to maintain alone. glad to have @Kerumen on board now.

if someone else is interested to come along let me know.

@Kerumen
Copy link
Collaborator

Kerumen commented Mar 3, 2017

Thanks for the push access! I'll do my best to maintain this module.

@tlvenn
Copy link

tlvenn commented Mar 5, 2017

@joonhocho now there is a new active maintainer, any chance to push back the changes on your fork here ?

@joonhocho
Copy link

@tlvenn I think two projects are in a state that's hard to be merged. I'm using Swift in mine, and APIs are quite different.

@tlvenn
Copy link

tlvenn commented Mar 9, 2017

Thanks for the feedback @joonhocho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants