Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm chart override fields to DevfileRegistry registry operator CRD #1439

Closed
5 tasks done
Tracked by #1274
michael-valdron opened this issue Feb 1, 2024 · 0 comments · Fixed by devfile/registry-operator#82
Closed
5 tasks done
Tracked by #1274
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Feb 1, 2024

Which area/kind this issue is related to?

/area registry

Issue Description

Using the helm chart, one can use the following override parameters:

  • hostnameOverride - overrides the entire ingress hostname and domain
  • nameOverride - overrides the app name
  • fullnameOverride - overrides the full app name

Hostname override example

helm install devfile-registry deploy/chart/devfile-registry ... --set hostnameOverride='dr.192.168.x.x.nip.io' ...

App name and full app name override example

helm install devfile-registry deploy/chart/devfile-registry ... --set nameOverride='dr' --set fullnameOverride='devfile-registry' ...

Acceptance Criteria

  • Implement hostnameOverride field
  • Implement nameOverride field
  • Implement fullnameOverride field
  • Create test case to set override fields
  • Run integration tests to verify changes
@michael-valdron michael-valdron changed the title Add helm chart override fields to registry operator DevfileRegistry CRD Add helm chart override fields to DevfileRegistry registry operator CRD Feb 1, 2024
@michael-valdron michael-valdron added the area/registry Devfile registry for stacks and infrastructure label Feb 1, 2024
@michael-valdron michael-valdron self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant