Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to add readiness/liveness probes to workspace containers #1132

Open
amisevsk opened this issue Jun 22, 2023 · 0 comments
Open

Add a way to add readiness/liveness probes to workspace containers #1132

amisevsk opened this issue Jun 22, 2023 · 0 comments

Comments

@amisevsk
Copy link
Collaborator

Description

The DevWorkspace Operator implements a rudimentary readiness probe (curling the mainUrl for a workspace) in order to verify that a workspace is actually running before marking it as ready.

However, this is not sufficient to detect issues with the workspace after it has been started; the mainUrl may stop responding at some point in the future, and if the DevWorkspace Operator doesn't happen to reconcile the DevWorkspace, it will not detect this issue.

Instead, we consider adding a way to define readiness/liveness probes for container components. Such a probe could continue to check the main URL for the workspace and kill the pod if it becomes unhealthy.

This is currently do-able in a somewhat roundabout way by using containerOverrides, so it may also make sense to continue using that as the supported approach.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant