Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring TLS Certs from external DWOC #1288

Open
AObuchow opened this issue Jul 15, 2024 · 0 comments
Open

Allow configuring TLS Certs from external DWOC #1288

AObuchow opened this issue Jul 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AObuchow
Copy link
Collaborator

Description

#1248 added support for configuring TLS certs in the global DWOC, however this feature cannot be used by an external DWOC.

The reason why setting TLS certs currently only work with the global DWOC is because the certs are used by a HTTP transport object that is shared between all workspaces. Since external DWOC's apply only to the workspace's that references them in their controller.devfile.io/devworkspace-config attribute, we need to be careful to clone (rather than directly modify) the global HTTP transport object when reconciling a workspace. See #1259 (comment)

Additional context

Supporting setting the tlsCertificateConfigmapRef from an external DWOC would allow for eclipse-che/che#22979.

@AObuchow AObuchow added the enhancement New feature or request label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant