Workspace is not failing if requirement is not satisfied

[benoitf]

Description

Start a devWorkspace with high "cpuLimit/memoryLimit"
We see logs about too many cpu requirements, etc but when listing the DevWorkspaces command is displaying "Waiting for workspace deployment"

$ oc get dw
NAME                    DEVWORKSPACE ID             PHASE      INFO
spring-petclinic-bnoj   workspace26699a51196d4b4c   Starting   Waiting for workspace deployment

but events of the platform are reporting

11m         Warning   FailedCreate             replicaset/workspace26699a51196d4b4c-6d58f65b64   Error creating: pods "workspace26699a51196d4b4c-6d58f65b64-k2n48" is forbidden: maximum cpu usage per Pod is 4, but limit is 6
11m         Warning   FailedCreate             replicaset/workspace26699a51196d4b4c-6d58f65b64   Error creating: pods "workspace26699a51196d4b4c-6d58f65b64-qx89t" is forbidden: maximum cpu usage per Pod is 4, but limit is 6
11m         Warning   FailedCreate             replicaset/workspace26699a51196d4b4c-6d58f65b64   Error creating: pods "workspace26699a51196d4b4c-6d58f65b64-5v2ms" is forbidden: maximum cpu usage per Pod is 4, but limit is 6

How To Reproduce

In Che, clicking on https://che-host#https://github.com/benoitf/spring-petclinic/tree/error-cpu

Expected behavior

DevWorkspace should report failure

Additional context

[ibuziuk]

PR - sent #701

[ibuziuk]

PR has been merged. Closing