Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change long press behaviour for tabs #147

Closed
msfjarvis opened this issue Jun 12, 2019 · 3 comments
Closed

Change long press behaviour for tabs #147

msfjarvis opened this issue Jun 12, 2019 · 3 comments
Milestone

Comments

@msfjarvis
Copy link

The long press action seems to create a dialog that simply shows the name of the tab. I personally find it to be a waste of precious contextual space, and instead would like to suggest repurposing it as a delete action, with a confirmation dialog or an undo UI flow, whatever feels more natural to you.

@brunolemos
Copy link
Member

brunolemos commented Jun 12, 2019

Thanks for the suggestion! Long pressing it will probably be used to reorder the columns.

#80 was started but it was not cross-platform so it was not merged. Pull Requests welcome!

@msfjarvis
Copy link
Author

I'm a native Android developer, React and Typescript are still not part of my skill set so I'll just wait for someone capable of executing this to drop by :)

@brunolemos
Copy link
Member

brunolemos commented Sep 10, 2019

Closing in favor of #42. Also on v0.95.0. this alert was removed.

@brunolemos brunolemos modified the milestones: v0.94.3, v0.95.0 Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants