-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias for the icon name to accomodate technologies being renamed #327
Comments
Thanks for the good ideas on this topic.
I like the second approach more since i think it's more intuitive, although I'm not very happy with having a growing model in our |
So some libraries have multiple names and I don't think it's necessary to make an alias for it. One, most people will know to try searching for the other alias. Two, when they use our site to search for the icon, they will see an icon regardless of what name they use. For example, So any cases that has a suffix at the (i.e javascript libraries) won't need an alias. I think we should revisit this in the future. I would like to minimize changes to the |
Oh, I missed this issue entirely. I made a PR on almost the exact same thing yesterday though, only difference is that it's called altnames instead of aka/aliases in my PR. Only good thing about adding suffixes like "js" that I found, is that most, if not all js libraries now show up if you just search for "js". So it can be used to sort of categorize icons. I think in the future it would be better to have more advanced search options, so you could choose if you want to search just for the name/altname/tag etc, or all of them. |
So, has anyone looked at the PR yet? |
I'm fine with it but the choice rests on the current maintainers of the team. I'm now more of a background passive maintainer so even though I'd love to accept the PR, I can't do much 😄 |
@amacado @Panquesito7 @maltejur |
@amacado @Panquesito7 |
Hello all,
I've been going over old issues. One of them involves creating alias for the name of technology because they got renamed. I think that this is a necessary feature to accommodate future changes or different naming scheme (
dot-net
anddotnet
for example).Here is a
devicon.json
object that we have:Based on this current interface, I can think of these solutions:
Create a new attribute called
aka
. It will be astring[]
that would look like this:or
aka
would be an empty array/list.angular
vsangularjs
) would not need the aliases if it's at the end of the name. I can add something in the CONTRIBUTING.md for that.Create a new attribute called
aliases
that would keep track of aliases of the technology name. The currentaliases
attribute (which tracks the versions) will be moved inside theversions
attribute. It would also be renamed tofont-aliases
for clear distinction. It can look like this:In order to achieve any of the above changes, we will need to:
css
generation task to create the name aliases.Priority: Low (in my opinion). We can do this after the
gh-pages
migration and thenpm
publish workflow.Let me know what you guys think. Feedback are welcome :)
The text was updated successfully, but these errors were encountered: