Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace raw.githubusercontent.com in devicon.dev with CDN (nosniff header problem) #572

Closed
d3cline opened this issue Apr 24, 2021 · 4 comments · Fixed by #586
Closed

Replace raw.githubusercontent.com in devicon.dev with CDN (nosniff header problem) #572

d3cline opened this issue Apr 24, 2021 · 4 comments · Fixed by #586
Labels
bug Use this label for pointing out bugs

Comments

@d3cline
Copy link

d3cline commented Apr 24, 2021

The CSS link on the demo site is broken due to mime type.
image
link needs to be updated to another CDN such as,
https://cdn.jsdelivr.net/gh/devicons/devicon/devicon.min.css

@d3cline d3cline added the request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue label Apr 24, 2021
@Panquesito7 Panquesito7 added bug Use this label for pointing out bugs and removed request:icon When requesting a new icon to be added to the collection or a refactor use this label in your issue labels Apr 24, 2021
@Panquesito7
Copy link
Member

Are you sure it's failing? I'm not receiving any error here.
Inspect: console

@amacado
Copy link
Member

amacado commented Apr 24, 2021

Hello @d3cline, thanks for pointing that out. It's true that some browsers (or settings) will block content which is requested from raw.githubusercontent.com. This is because of the nosniff header provided by github.

image

This issue does not occur for every user (I don't have it either) but in some scenarios it will lead to the error you are describing. It probably can be resolved by using a CDN as deliverer of the files. When this is beeing fixed note that not only the css files are loaded via githubusercontent but also the svg.

image

See this thread for more information about the topic.

@amacado amacado changed the title Site CSS broken. Replace raw.githubusercontent.com in devicon.dev with CDN (nosniff header problem) Apr 24, 2021
@amacado amacado linked a pull request May 1, 2021 that will close this issue
@roythearsonist
Copy link
Contributor

If there were two prs that fix this, why is this still open

@amacado
Copy link
Member

amacado commented Aug 6, 2021

Yep, can be closed since it's done.

@amacado amacado closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants