-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Discord icon on website #1039
Conversation
This reverts commit fcff629.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! Sorry about your effort, but we already fixed the Discord logo in #909. Although I like how it matches the color of the GitHub icon. What do you think, @Thomas-Boi?
I agree @Panquesito7. Since the logo has already been fixed, this PR would be redundant. Thank you very much for your work though |
Hmm, what if we accept this PR? 😅 I like how the logo matches the GitHub icon. What do you think? Thanks. :) |
@Thomas-Boi thankyour. Perhaps you should consider updating the colour scheme of the buttonLinks for Discord. and also closing the bug #907. |
Do you mean the color or the shape? I'm fine with either one. |
Also, if we do accept this PR, perhaps it can be made by rebasing our current develop. This PR contains commits from the vuetify PR, which might duplicate some stuff |
Fixed now. :) |
@Thomas-Boi @Panquesito7 Thank you. I'am glad Devicon is accepting my new changes. |
New feature section
Double check these details before you open a PR
This PR fixes
The discord icon in the buttonLink section of the page is updated with latest discord logo considering the bug #907
This new logo style matches the primary colour theme of Devicon
#60be86
, which matches with other icons within the section.Present Discord buttonLink design
The logo is outdated.
doesn't match colour scheme of the website.
New Discord buttonLink design
The new logo is latest Discord logo. verify here
The new logo is matched with colour Scheme of the website with
#60be86
Notes
This pull request is to resolve issue #907.