Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: rancher (original, original-wordmark, plain-wordmark, line, line-wordmark) #2014

Merged
merged 2 commits into from
Nov 20, 2023
Merged

update icon: rancher (original, original-wordmark, plain-wordmark, line, line-wordmark) #2014

merged 2 commits into from
Nov 20, 2023

Conversation

canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Line versions created, and I removed the plain-wordmark alias as the original-wordmark had 2 different paths with different fills.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 18, 2023
@Snailedlt Snailedlt mentioned this pull request Nov 19, 2023
Closed
@Snailedlt Snailedlt requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team November 19, 2023 23:16
weh
weh approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, nothing to complain 👍

Snailedlt
Snailedlt approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Looks Great! 💯 Thank you for another great PR! 🙇‍♂️
image
image
image
image
image

@Snailedlt Snailedlt merged commit fcda32a into devicons:develop Nov 20, 2023
5 checks passed
@lunatic-fox lunatic-fox mentioned this pull request Jan 10, 2024
Merged
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canaleal @weh @Snailedlt