Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icon: visualstudio (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) #2074

Merged
merged 7 commits into from
Dec 23, 2023

Conversation

canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

I was unable to find a wordmark svg for 2022 Visual Studio. It seems like only visual studio
The dark purple color #52218a was used for the font SVGs.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 29, 2023
lunatic-fox
lunatic-fox previously approved these changes Nov 30, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍🏼
Thank you for this contribution! 🚀
image
image

@lunatic-fox lunatic-fox requested review from Snailedlt, a team, ConX and weh and removed request for a team November 30, 2023 17:37
Snailedlt
Snailedlt previously approved these changes Dec 5, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again!
I couldn't find any official wordmark versions either, but I swear I've seen it somewhere. Perhaps we could vectorize this version?
https://archive.org/details/visualstudio-2022-community-j
image

@Snailedlt
Copy link
Collaborator

@canaleal I'll let you decide if you want to try making wordmark versions, or if you just want to merge it. Either is fine by me :)

@canaleal
Copy link
Member Author

canaleal commented Dec 5, 2023

I'm gonna try to vectorize the wordmark image. Also yeah, I distinctly remember seeing a wordmark svg some time ago.

@lunatic-fox
Copy link
Contributor

lunatic-fox commented Dec 6, 2023

Here goes a suggestion based on the original version.

I'm still have problems with Filezilla gradient (text) as I'm having here in this icon. 💡 I know how to solve it now.
Another thing is that the colors and the proportion of the lemniscata styled icon is a little bit different from original version.

Updated version - with gradient

@Snailedlt
Copy link
Collaborator

@canaleal whenever you have time, please add the wordmark versions :)
See lunatic-fox's suggestion in the comment above

Co-authored-by: lunatic-fox <76992016+lunatic-fox@users.noreply.github.com>
@Snailedlt Snailedlt dismissed stale reviews from lunatic-fox and themself via be2db42 December 23, 2023 12:41
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the wordmark suggestion made by @lunatic-fox, and made plain + line versions of it.
Everything looks good now! ✅
image
image
image

@Snailedlt Snailedlt merged commit 6e214bb into devicons:develop Dec 23, 2023
5 checks passed
@Snailedlt Snailedlt changed the title update icon: visualstudio (original, plain, line) update icon: visualstudio (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Dec 23, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants