Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the svg checker so it doesn't post confirmation messages and updated CONTRIBUTING.md #542

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Mar 29, 2021

This PR is to resolve issues #534 and another PR where there were issues with our naming convention.

From now on, all names will be lowercase and concatenated. If the original name has a hyphen, I supposed it can be kept. The build script should have no issue with hyphens in name for building CSS or icon files. As long as it matches the svg files, it works.

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a deep test this looks good to me! :) I just have the feeling that cutenode/action-always-fail@v1.0.1 could be replaced without a vendor action. If I get it right, this action will just fail? This could probably done without any vendor component, or?

Anyway: Thanks for improving and you have my approval! @Panquesito7 might wanna take a look before merging?

@Panquesito7 Panquesito7 added the devops Use this label for devops related enhancements label Mar 30, 2021
@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Mar 30, 2021

Without a deep test this looks good to me! :) I just have the feeling that cutenode/action-always-fail@v1.0.1 could be replaced without a vendor action. If I get it right, this action will just fail? This could probably done without any vendor component, or?

That's true. I originally wanted to have a clean way to fail the workflow and this action seems to be it. If this fails because of the action, we would have a message that says "This action intentionally fails etc..." rather than if we run a bogus command like "fake-command". If we run into any weird issues I'll fail the script manually 👍

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👍 🎉

@Thomas-Boi Thomas-Boi merged commit 6e0d7a5 into develop Mar 30, 2021
@Panquesito7 Panquesito7 deleted the thomas/feature/workflowAndContributing branch March 30, 2021 16:33
@Thomas-Boi Thomas-Boi linked an issue Apr 2, 2021 that may be closed by this pull request
@amacado amacado mentioned this pull request Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the SVG checker bot stop posting comments after each commit
3 participants