Optimize bot is now a part of the build script #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amacado
approved these changes
May 27, 2021
This was referenced Jun 13, 2021
Merged
Thomas-Boi
added a commit
that referenced
this pull request
Jun 13, 2021
* Add arduino icon * Update all icon types * Add to icon registry * Update arduino icons * Update arduino icons * Remove vscode folder * Update icons/arduino/arduino-original-wordmark.svg * Update icons/arduino/arduino-original.svg * Update icons/arduino/arduino-plain-wordmark.svg * Update icons/arduino/arduino-plain.svg * enhance guidelines for drafting a new release * Bump ini from 1.3.5 to 1.3.8 (#562) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Added a section for common bugs in the CONTRIBUTING (#563) * new icon: nixos (original, original-wordmark, plain, plain-wordmark) (#564) * new icon: nixos (original, original-wordmark, plain, plain-wordmark) * icon nixos: optimize the svgs * icon nixos: add newline at end of svgs * icon nixos: remove extra line * feat: Added perl icons * chore: Simplify svg files * fix: size fixes * fix: Removed aliases from json * Add aliases (fixes the script) * Update devicon.json * Update devicon.json * fix: Renamed icons * fix: Cleaned up svg files and ran svg opimizer * Delete arduino-plain-wordmark.svg Deleted the faulty svg * Add Icomoon arduino-plain-wordmark.svg * Rename arduino-plain-workmark.svg to arduino-plain-wordmark.svg * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Script upgrades and updated CONTRIBUTING.md and README.md (#576) * Updated README and CONTRIBUTING * Added check for devicon object when peeking * Added PR template * Added a script to create release messages * Updated CONTRIBUTING about new script * Update .github/PULL_REQUEST_TEMPLATE/new_icon.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/scripts/build_assets/arg_getters.py Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/workflows/get_release_message.yml Co-authored-by: David Leal <halfpacho@gmail.com> * Update gulpfile.js Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/PULL_REQUEST_TEMPLATE/new_feature.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/PULL_REQUEST_TEMPLATE/new_feature.md Co-authored-by: David Leal <halfpacho@gmail.com> * Added a way for peek bot to comment error * Update CONTRIBUTING.md Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update .github/scripts/get_release_message.py Co-authored-by: Malte Jürgens <maltejur@web.de> * Update .github/scripts/get_release_message.py Co-authored-by: Malte Jürgens <maltejur@web.de> * Update .github/PULL_REQUEST_TEMPLATE/new_feature.md Co-authored-by: David Leal <halfpacho@gmail.com> * Clean up and updated CONTRIBUTING * Updated CONTRIBUTING * Add set up steps for release message workflow * Refactored peek workflow * Added requests library * Reformat devicon object error messages Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Malte Jürgens <maltejur@web.de> * new icon: tensorflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) * new icon: tensorflow (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) * resized svgs * cleaned up svgs * compressed svgs and updated viewboxes * new icon: zig (original, original-wordmark, plain-wordmark) * Replace raw.githubusercontent.com with jsdelivr (#586) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * recommended svg fixes * Clean up and CONTRIBUTING upgrade (#595) * Updated CONTRIBUTING * Clean up various scripts (no functional changes) * Update CONTRIBUTING.md Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Change icons to use devicon in README and CONTRIBUTING * Add optimize-bot into CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update README.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update README.md Co-authored-by: David Leal <halfpacho@gmail.com> * Change release message step name * Update CONTRIBUTING.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update CONTRIBUTING.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update CONTRIBUTING.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update CONTRIBUTING.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update CONTRIBUTING.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update CONTRIBUTING.md Co-authored-by: David Leal <halfpacho@gmail.com> * Changed all 'svg' to "SVG" Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> * Optimized SVG using SVGO (#597) * Added script to optimize svgs * Updated the svgs using svgo * Made the optimize svg script into a workflow * Added npm install step * Change the env variable bug * Clean up and updated check svg * Change label name * Fix python wordmark icon (#103) * Fix python wordmark icon * Update icons/python/python-original-wordmark.svg Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * New icon: raspberrypi (original, original-wordmark, line, line-wordmark) (#609) * Add rpi icon * Add original. Remove `enable-background`. Fix font colors * Add icons to list * Fix formatting * Add official RPi logo + eps. Update svg and font * Updated raspberry icons * Optimized the SVGs Co-authored-by: Herman Singh <kartstig@gmail.com> Co-authored-by: Thomas-Boi <Thomas-Boi@users.noreply.github.com> * New icon: tailwindcss (plain) (#610) * Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> * Bump lodash from 4.17.20 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> * Create README.md * Add files via upload * Delete README.md * Update devicon.json * new file added * file added * Delete jamstack-plain.svg * Add files via upload * Delete icons/jamstack directory Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Updated and optimized python svgs (#622) * Updated and optimized python svgs * Update icons/python/python-original.svg Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: labview (original, original-wordmark, plain, plain-wordmark) (#626) * add labview icon (original, plain, original-wordmark, plain-wordmark) * Updated labview svgs Co-authored-by: Marc LaBelle <mlabelle@acvauctions.com> * new icon: modx (original, original-wordmark, plain, plain-wordmark) (#627) * Submitting MODX logo MODX is a popular open source PHP CMS. Its logo is also found in FontAwesome, seems like it would be great for it to have * Updated devicon.json and modx svg color * Fixed issues reported by svg-checker bot Co-authored-by: JP DeVries <mail@devries.jp> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: knockout (plain-wordmark) (#628) * Added Knockout icon (plain workmark only) * Updated devicon.json Co-authored-by: Adriano Ueda <adriano.ueda@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: embeddedc (original, plain, original-wordmark, plain-wordmark) (#625) * add embeddedc icon (original, plain, original-wordmark, plain-wordmark) * Convert style to fill * Remove merge error in devicon.json Co-authored-by: Marc LaBelle <mlabelle@acvauctions.com> * Optimize bot is now a part of the build script (#624) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Add extra requirement in new icon pr template (#642) * Add extra requirement in new icon pr template * Update .github/PULL_REQUEST_TEMPLATE/new_icon.md Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: rstudio (orignal. plain) (#634) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: phalcon (original, plain) (#635) * Add phalcon svgs * Change style to fill attribute Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: minitab (original, plain) (#636) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: bulma (plain) (#638) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: spss (original, plain) (#639) * Add spss svgs * Addressed svg bot's issues Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: jest (plain) (#647) Co-authored-by: Raúl Julián López Caña <rjlopezmad@gmail.com> * update public-upload-to-imgur action v2.2.2 (#651) * update public-upload-to-imgur action v2.2.2 * update imgur upload action to v2.2.2 * new icon: karma (original, plain) (#646) Co-authored-by: Raúl Julián López Caña <rjlopezmad@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: circleci (plain, plain-wordmark) (#648) Co-authored-by: Raúl Julián López Caña <rjlopezmad@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: shopware (original, original-wordmark) (#653) * Shopware Adding SHopware icons * Fixed check svgbot issues Co-authored-by: Mariya Videva <mariaavideva@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: salesforce (original, plain) (#654) * SalesForce Adding SalesForce icons * Fixed check svg errors Co-authored-by: Mariya Videva <mariaavideva@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: vuestorefront (original, plain) (#655) * vue StoreFront vue StoreFront icons * Update vuestorefront-plain Co-authored-by: Mariya Videva <mariaavideva@gmail.com> * new icon: codecov (plain) (#649) * Add Codecov icons (plain) * Update codecov-plain * Centered codecov plain Co-authored-by: Raúl Julián López Caña <rjlopezmad@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Add Unix icon (#659) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Peek bot won't check whether icon is in icomoon (#657) Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: magento (original, original-wordmark, line) (#652) * Magento Adding Magento Icon * Fix issues reported by check svg bot * Fixed magento line Co-authored-by: Mariya Videva <mariaavideva@gmail.com> * Fix svg checker double posting comment (#660) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Update issue and PR templates (#658) * Update issue and PR templates * Added icon requirements to contributing * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/ISSUE_TEMPLATE/feature_request.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/ISSUE_TEMPLATE/feature_request.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/ISSUE_TEMPLATE/feature_request.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/ISSUE_TEMPLATE/icon-request.md Co-authored-by: David Leal <halfpacho@gmail.com> * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> * Update bug_report.md * Update .github/PULL_REQUEST_TEMPLATE/new_feature.md Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/PULL_REQUEST_TEMPLATE/new_feature.md Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: godot (original, original-wordmark, plain, plain-wordmark) (#663) * new icon: godot (original, original-wordmark, plain, plain-wordmark) * Minor fix Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: vscode (original, original-wordmark, plain, plain-wordmark) (#664) * new icon: julia (original, original-wordmark, plain, plain-wordmark) (#665) * Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> * Bump lodash from 4.17.20 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> * new icon: julia (original, original-wordmark, plain, plain-wordmark) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: matlab (line) (#640) * Add matlab-line * Fixed issues reported by check svg bot * optimisation for svg (#643) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: crystal (original, original-wordmark) (#667) * typo & grammar fixes in readme (#670) * Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> * Bump lodash from 4.17.20 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> * Typo + grammar fixes. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Build bot now build new SVGs in folder that were already built (#666) * Refactor the pull request fetching code * Refactor build script to use past PRs * Added function to update icomoon json * new icon: matlab (line) (#640) * Add matlab-line * Fixed issues reported by check svg bot * optimisation for svg (#643) Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> * Add better logging to icomoon_build Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: tailwindcss (wordmark) (#671) * Bump hosted-git-info from 2.8.8 to 2.8.9 Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> * Bump lodash from 4.17.20 to 4.17.21 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> * added tailwindcss wordmark * updated commit * updated * done Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Minor update to CONTRIBUTING and post peek (#672) * Fix duplicated past icons in build process (#674) * Fixed issue with wrong name referencing from github api (#677) * bump npm version to v2.12.0 * Built new icons, icomoon.json and devicon.css (#678) Co-authored-by: Thomas-Boi <Thomas-Boi@users.noreply.github.com> Co-authored-by: Herman Singh <kartstig@gmail.com> Co-authored-by: Enis Mulić <enis.s.mulic@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jeovazero <jeovazero@users.noreply.github.com> Co-authored-by: Matt Koskela <mattkoskela@gmail.com> Co-authored-by: Malte Jürgens <maltejur@web.de> Co-authored-by: reevesba <reevesbra@outlook.com> Co-authored-by: AtomToast <reg-2@t-online.de> Co-authored-by: Thomas-Boi <Thomas-Boi@users.noreply.github.com> Co-authored-by: Utkarsh Mishra <76392681+Utkarsh1504@users.noreply.github.com> Co-authored-by: Marc LaBelle <mlabelle@acvauctions.com> Co-authored-by: JP DeVries <mail@devries.jp> Co-authored-by: Adriano Ueda <adriano.ueda@gmail.com> Co-authored-by: Raúl Julián López Caña <rjlopezmad@gmail.com> Co-authored-by: Mariya Videva <mariaavideva@gmail.com> Co-authored-by: Chrıs Seelus <cseelus@gmail.com> Co-authored-by: Ben Hampson <77866043+Ben-Hampson@users.noreply.github.com> Co-authored-by: Saket Kothari <81709725+SaketKothari@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the current optimize workflow into a part of our new release build process.
Here's how it works:
We decide to make a new release
We trigger the build script
Before the script uploads the SVGs to Icomoon, it will optimize them in batches. This is to prevent issues with command line character limits.
The PR action will commit the optimization along with the new icon files.
I've tested the file and it works well:
Note that some of the files are re-optimized (zig, raspberrypi, etc...). I manually check the files and see no difference. I'm guessing that re-running the optimize script would round some value again. Also, these file changes are not part of the PR.