Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #694

Merged
merged 7 commits into from
Jun 30, 2021
Merged

Update CONTRIBUTING.md #694

merged 7 commits into from
Jun 30, 2021

Conversation

Thomas-Boi
Copy link
Member

Contain:

  • Remove references about contributors having to optimize the SVGs manually
  • Update the requesting icon section

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work, Thomas.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Thomas-Boi
Copy link
Member Author

IMPORTANT

The latest commit also fixes #693, which renames the vueStorefront folder to vuestorefront. Git Bash somehow doesn't register the name change as a commitable change => I had to batch it in with other changes. Let's see if it works. If it doesn't, I'll figure out another way

@amacado amacado merged commit 1b018fb into develop Jun 30, 2021
@amacado
Copy link
Member

amacado commented Jun 30, 2021

@Thomas-Boi i assume the vuestorefront fix was not successful. I approve this request anyway to update the CONTRIBUTING.md.

@amacado amacado deleted the thomas/contributeUpdate branch June 30, 2021 09:41
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants