Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: denojs (original, original-wordmark) #713

Merged
merged 27 commits into from
Jul 4, 2021
Merged

new icon: denojs (original, original-wordmark) #713

merged 27 commits into from
Jul 4, 2021

Conversation

informeai
Copy link
Contributor

made due correction of deno svg and update of devicon.json 👍🏼

dependabot bot and others added 22 commits May 11, 2021 02:39
@dependabot
Bump hosted-git-info from 2.8.8 to 2.8.9
3436ea2 
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>
@Thomas-Boi
Merge pull request devicons#603 from devicons/dependabot/npm_and_yarn…
563d9cf 
…/hosted-git-info-2.8.9

Bump hosted-git-info from 2.8.8 to 2.8.9
@dependabot
Bump lodash from 4.17.20 to 4.17.21
c259984 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
@Thomas-Boi
Merge pull request devicons#604 from devicons/dependabot/npm_and_yarn…
7a4ca8a 
…/lodash-4.17.21

Bump lodash from 4.17.20 to 4.17.21
@Thomas-Boi
Merge pull request devicons#682 from devicons/develop
9f4f5cd 
Release v2.12.0
Resolves issue devicons#260
3dfff02
@amacado
Merge branch 'develop' into master
bb05165
@Panquesito7
Make the original icon version pure SVG
7d7456c 
Taken from [Wikipedia](https://es.wikipedia.org/wiki/Archivo:Deno.svg).
@Panquesito7
Make the original-wordmark icon pure SVG
e6ec064
@Thomas-Boi @Panquesito7
Apply suggestions from code review
280c179 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Thomas-Boi
Merge branch 'develop' into master
b7ee174
svg concert for denojs
6db0480 
resolves devicons#709
update devicon.json and resolves devicons#260
9e3915a
merge pull
40556bb
update devicon.json and resolve devicons#260
1aa373c
delete files repeats
4729106
@Panquesito7
Delete denojs-plain-wordmark.svg
45697f4
@Panquesito7
Delete denojs-plain.svg
5ef72f6
@Panquesito7
Update denojs-original-wordmark.svg
070e97c
@Panquesito7
Update denojs-original.svg
d631655
@Panquesito7
Update denojs-original.svg
08da1b0
@Panquesito7
Update denojs-original-wordmark.svg
7d5838e
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 4, 2021
@github-actions

This comment has been minimized.

Sign in to view
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 4, 2021
@Panquesito7 Panquesito7 changed the title new icon: denojs(original,original-wordmark,plain,plain-wordmark) new icon: denojs (original, original-wordmark) Jul 4, 2021
@devicons devicons deleted a comment from github-actions bot Jul 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Couldn't find an icon matching the name in the PR title.

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

Panquesito7
Panquesito7 reviewed Jul 4, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thomas-Boi, any reasons why the Peek Bot workflow is failing? For me, all looks good. 🤔

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 4, 2021
@Thomas-Boi
Copy link
Member

Hey @informeai and @Panquesito7,

Good news: the peek bot is working now; I have no ideal why it failed before. On the other hand, the SVGs don't look great as icons (see above). Can you please fix it so the white parts are transparent instead of white?

Panquesito7
Panquesito7 reviewed Jul 4, 2021
View reviewed changes
icons/denojs/denojs-original-wordmark.svg Outdated Show resolved Hide resolved
icons/denojs/denojs-original.svg Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 4, 2021
@Panquesito7
Copy link
Member

Let's see if that fixes it...😅

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@devicons devicons deleted a comment from github-actions bot Jul 4, 2021
Panquesito7
Panquesito7 approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @informeai. Thank you for your contribution! 👍 🎉

Thomas-Boi
Thomas-Boi approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great now! Thanks for your work 😃

@Panquesito7 Panquesito7 merged commit b13b02d into devicons:develop Jul 4, 2021
@informeai
Copy link
Contributor Author

Happy to contribute ☺️, thanks @Thomas-Boi and @Panquesito7 🙏🏻👍🏻

@Thomas-Boi Thomas-Boi mentioned this pull request Aug 14, 2021
Merged
@amacado amacado mentioned this pull request Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Thomas-Boi Thomas-Boi Thomas-Boi approved these changes

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@informeai @Thomas-Boi @Panquesito7 @amacado