-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: msdos (original) #726
Conversation
- re-sorted icons starting with 'm' alphabetically
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
Added msdos viewport Co-authored-by: David Leal <halfpacho@gmail.com>
Added msdos aliases Co-authored-by: David Leal <halfpacho@gmail.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
Seems like the |
Hi! I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs. Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the SVGs looks good. There are just a few things I'd like to see changed:
- Add the
line
version to thedevicon.json
'sfont
attribute. This should be font-friendly. - Simplify the
plain
version a bit more. Currently, it has more than one color. There should only be one color in the whole SVG for theplain
version. Pick the primary color and change all the other colors to that.
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the version
version looks good, but the plain
version doesn't look so good. @Thomas-Boi, what do you think we should do? 🤔
Co-authored-by: David Leal <halfpacho@gmail.com>
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line
version looks good, but the plain
doesn't. Could you please fix it?
Why doesn't it look good? |
I already know what does it say, but for other users, it would be kind of hard to understand, as it looks all black and the letters are very much together. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, never mind. Now that I think about it well, it looks great! I love it. Great work, @MichielPater! Thank you for your patience, dedication, and contributions to our community! 😄👍🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @MichielPater for the late response.
I think the icons and SVGs all look good. I'll merge your changes in. Thank you for your dedication in seeing this through 😃, we really appreciate it.
And re-sorted icons starting with 'm' alphabetically.