Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: msdos (original) #726

Merged
merged 21 commits into from
Aug 7, 2021
Merged

new icon: msdos (original) #726

merged 21 commits into from
Aug 7, 2021

Conversation

MichielPater
Copy link
Contributor

And re-sorted icons starting with 'm' alphabetically.

- re-sorted icons starting with 'm' alphabetically
@MichielPater MichielPater changed the base branch from master to develop July 7, 2021 18:09
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/msdos/msdos-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

icons/msdos/msdos-original.svg Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
MichielPater and others added 2 commits July 7, 2021 21:28
Added msdos viewport

Co-authored-by: David Leal <halfpacho@gmail.com>
Added msdos aliases

Co-authored-by: David Leal <halfpacho@gmail.com>
@Thomas-Boi Thomas-Boi added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jul 9, 2021
@github-actions

This comment has been minimized.

devicon.json Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
MichielPater and others added 2 commits July 9, 2021 11:32
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi
Copy link
Member

Seems like the original version is not icon friendly (see peek-bot's image). I'm not sure on the best way to approach this... Can you try stripping the colors manually and upload it as a plain version? Still keep the original but has a plain version that's already simplified and stripped of colors. I'll run the bot again and we'll see how it goes.

@github-actions
Copy link
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/msdos/msdos-line.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/msdos/msdos-plain.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the SVGs looks good. There are just a few things I'd like to see changed:

  • Add the line version to the devicon.json's font attribute. This should be font-friendly.
  • Simplify the plain version a bit more. Currently, it has more than one color. There should only be one color in the whole SVG for the plain version. Pick the primary color and change all the other colors to that.

icons/msdos/msdos-line.svg Outdated Show resolved Hide resolved
icons/msdos/msdos-plain.svg Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 25, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the version version looks good, but the plain version doesn't look so good. @Thomas-Boi, what do you think we should do? 🤔

Co-authored-by: David Leal <halfpacho@gmail.com>
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 27, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line version looks good, but the plain doesn't. Could you please fix it?

@MichielPater
Copy link
Contributor Author

The line version looks good, but the plain doesn't. Could you please fix it?

Why doesn't it look good?

@Panquesito7
Copy link
Member

The line version looks good, but the plain doesn't. Could you please fix it?

Why doesn't it look good?

I already know what does it say, but for other users, it would be kind of hard to understand, as it looks all black and the letters are very much together. The line version looks very good though. Hope I get to understand, thanks. 🙂

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, never mind. Now that I think about it well, it looks great! I love it. Great work, @MichielPater! Thank you for your patience, dedication, and contributions to our community! 😄👍🎉

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @MichielPater for the late response.

I think the icons and SVGs all look good. I'll merge your changes in. Thank you for your dedication in seeing this through 😃, we really appreciate it.

@Thomas-Boi Thomas-Boi merged commit 99dfcf6 into devicons:develop Aug 7, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants