-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: pandas (original, original-wordmark) #796
Conversation
Why is numpy also in this branch history |
The branch history includes numpy files since I've opened those files to benchmark pandas files (to not make any mistake). Sorry for causing confusion :( |
Requested changes are now reflected. |
It seems all checks have failed after the changes on the SVGs due to their qualities. Shall I try resizing the them (maybe using svgminifyer)? |
For some reason GitHub is not allowing us to view the logs of the workflow. We'll have to wait and see what issue is later |
Issues with the CI have been fixed now. |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Amazing work, @kimjiwook0129; thank you for your contribution! 😄👍🎉
Thank you! |
Hi @kimjiwook0129, The icons look good to me. However, we are currently pausing accepting new icons until the next release. This is due to an upgrade to our peek and check-svg bot that we need to implement before checking further icon. This PR will be left open until the next release. Once that's done, we will re-run peek-bot and merge it then 👍 |
Sounds good, thank you! |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like: You can click on the pictures and zoom on them if needed. The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons look good both as SVG and icons! Thank you @kimjiwook0129
new icon: pandas (original, original-wordmark)