Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: pandas (original, original-wordmark) #796

Merged
merged 18 commits into from
Aug 16, 2021

Conversation

kimjiwook0129
Copy link
Contributor

new icon: pandas (original, original-wordmark)

@roythearsonist
Copy link
Contributor

Why is numpy also in this branch history

@kimjiwook0129
Copy link
Contributor Author

Why is numpy also in this branch history

The branch history includes numpy files since I've opened those files to benchmark pandas files (to not make any mistake).
In such benchmark process, I've copied few lines to compare and I think that should have included in the history.
But nothing's been edited on 'icons/numpy/*'

Sorry for causing confusion :(
Is there anything I can do to remove redundancy on the branch history?

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Aug 10, 2021
icons/pandas/pandas-original.svg Outdated Show resolved Hide resolved
icons/pandas/pandas-original-wordmark.svg Outdated Show resolved Hide resolved
devicon.json Show resolved Hide resolved
@kimjiwook0129
Copy link
Contributor Author

Requested changes are now reflected.

@kimjiwook0129
Copy link
Contributor Author

It seems all checks have failed after the changes on the SVGs due to their qualities. Shall I try resizing the them (maybe using svgminifyer)?

icons/pandas/pandas-original.svg Outdated Show resolved Hide resolved
@Thomas-Boi
Copy link
Member

For some reason GitHub is not allowing us to view the logs of the workflow. We'll have to wait and see what issue is later

@Panquesito7
Copy link
Member

Issues with the CI have been fixed now.

@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 11, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Amazing work, @kimjiwook0129; thank you for your contribution! 😄👍🎉

@kimjiwook0129
Copy link
Contributor Author

Thank you!

@Thomas-Boi
Copy link
Member

Hi @kimjiwook0129,

The icons look good to me. However, we are currently pausing accepting new icons until the next release. This is due to an upgrade to our peek and check-svg bot that we need to implement before checking further icon.

This PR will be left open until the next release. Once that's done, we will re-run peek-bot and merge it then 👍

@kimjiwook0129
Copy link
Contributor Author

Sounds good, thank you!

@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 16, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like:
Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons look good both as SVG and icons! Thank you @kimjiwook0129

@Thomas-Boi Thomas-Boi merged commit 664c588 into devicons:develop Aug 16, 2021
This was referenced Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants