-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the check-bot
#970
Update the check-bot
#970
Conversation
Hi! I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue. Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience. Cheers, |
…evicons/devicon into thomas/feature/checkBotUpgrade
@amacado @Panquesito7 this is a big PR so let me know if you have any questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know too much about this, but overall it looks good to me. Thanks! 🚀
Hi @amacado, this PR is changing the Check SVG action. This is interfering with the merging process because "Check the SVGs' quality" action is not running anymore. Can you remove this requirement for the PR to be merged please? |
* new icon: kaggle (original, original-wordmark) (#835) * new icons added * Updated icons/kaggle/kaggle-original-wordmark.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Updated devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Updated icons/kaggle/kaggle-original.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Update kaggle-original-wordmark.svg * Update kaggle-original.svg * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Add pytest icons * Resize images and change color * Readd viewbox (removed by svgo) * Add opencv icons * Update tag Co-authored-by: David Leal <halfpacho@gmail.com> * Update color for opencv Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: fastapi (original, original-wordmark, plain, plain-wordmark) (#873) * Add FastAPI icons * Fix svg conversion * new icon: k3s (original, original-wordmark, plain, plain-wordmark) (#878) * Add k3s icons * Remove original to reduce file size * Move file and add alias * Update devicon.json Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: packer (original, original-wordmark) (#883) * new icon: anaconda (original, original-wordmark) (#884) * new icon: anaconda (original, original-wordmark) * Update devicon.json Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: rspec (original, original-wordmark) * new icon: argocd (original, original-wordmark, plain, plain-wordmark) (#889) * new icon: argocd (original, original-wordmark, plain, plain-wordmark) * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Rename argo-original-wordmark.svg to argocd-original-wordmark.svg * Rename argo-original.svg to argocd-original.svg * Rename argo-plain.svg to argocd-plain.svg * Rename argo-plain-wordmark.svg to argocd-plain-wordmark.svg * Add missing svg types Co-authored-by: David Leal <halfpacho@gmail.com> * Use correct svg for font Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: prometheus (original, original-wordmark) (#886) * new icon: prometheus (original, original-wordmark, plain, plain-wordmark) Signed-off-by: amino19 <anshumaankrprasad76@gmail.com> * viewBox='0 0 128 128' * viewBox='0 0 128 128' * removed plain files * Apply suggestions from code review * Apply suggestions from code review * Update devicon.json * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: blender (original, original-wordmark) (#892) * Added files * Add Blender icon files * Swap to line * Deletion of old original icon * Update json * Removal of accidental file insertion * Removal of whitespace and resize * Rename from line to original * Viewport fix * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: cmake (original, plain, original-wordmark, plain-wordmark) (#901) * new icon: cmake (original, plain, original-wordmark, plain-wordmark) * compress svgs * rename svgs * rename svgs * Update the Code of Conduct to the latest version * fix: endlines in the CMake icons (#902) * Fix: Outdated discord logo (#909) * Update discord-logo.svg * Update discord-logo.svg * Update docs/assets/css/discord-logo.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Logo fixed on the home page. * Discord logo fixed on the home page * Update docs/assets/css/discord-logo.svg Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> * Add contact information in the issue... (#908) ...template configuration. Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * fix: make `tags` an array for `elixir` (#914) * feat: Improve SEO * new icon: jetbrains (plain) (#899) * fixed: JetBrains plain svg file * Changes done * changing plain.svg for JetBrains * refactoring plain svg file Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: nuget (original, original-wordmark) (#912) * add nuget-original and nuget-original-wordmark * add nuget to devicon.json * fix viewport * merge paths * Rename nuget-original-watermark.svg to nuget-original-wordmark.svg * added missing endline to `original` and optimized * centered `original-wordmark` and fixed endline Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: networkx (original) (#917) * add `networkx-original` * add networkx to devicon.json * Apply suggestions from code review * convert strokes to paths Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: podman (original, original-wordmark) (#916) * new icon: podman (original, original-wordmark) * Remove svg background * Add plain versions * Update icons/podman/podman-plain-wordmark.svg * Update icons/podman/podman-plain.svg Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * update icon: django (plain, plain-wordmark) (#942) * update icon: django (plain, plain-wordmark) * add newlines not this time @Panquesito7 :D * Update `CONTRIBUTING.md` with Devicon line logos (#941) * change line logos from apache to devicon * Added link to line logo explanation * change title to devicon-line.svg Co-authored-by: David Leal <halfpacho@gmail.com> * change title to devicon-line-wordmark.svg Co-authored-by: David Leal <halfpacho@gmail.com> * undo commit 7f7b7da * remove link to script-tutorials.com Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * Added resources section to `CONTRIBUTING.md` (#975) * Added resources section to `CONTRIBUTING.md` * align headers to the left * Update CONTRIBUTING.md Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Add copy to clipboard button to website * New Feature: Upgrade Peekbot (#966) * Moved stroke detection down * Add code to retry no connection in peekbot * Change upload artifact to earlier version * Clean up logging msg * Add ability to customize port number * Update Selenium and geckodriver * Move upload-artifact version to 2.2.4 * Add logging for webdriver retry * Add color checking to peek-bot * new icon: sqlite (original, original-wordmark, plain) (#926) * new icon: sqlite (original, original-wordmark, plain) * resized viewbox to 0 0 128 128 * Added plain-wordmark * Centered and resized icons to fit viewbox * optimized SVG's with inkscape * Resized to 0 0 128 128 viewbox * optimized SVG's with inkscape again * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Add styling for color picker * Color picker menu can now be toggled * Add color reset functionality * Add checkerboard functionality * Add color picker to svg section * Add contact info and more legal details * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon-original-wordmark (#981) * update icon: bootstrap (original, original-wordmark, plain, plain-wordmark) (#982) * Update bootstrap svgs * Update devicon.json * Convert text to path * new icon: discordjs (original, original-wordmark, plain, plain-wordmark) (#937) * Added Discord.js Icons * Oops! * Forgot to add aliases. Co-authored-by: David Leal <halfpacho@gmail.com> * Change original wordmark to real SVG * Add plain-wordmark * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Apply suggestions from code review * Fixed wordmark * Rename discordjs-plain.svg to discordjs-original.svg * Create discordjs-plain.svg * Update discordjs-plain.svg * Update discordjs-plain.svg * Update discordjs-plain.svg * Update icons/discordjs/discordjs-plain.svg * Update discordjs-plain.svg * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: solidity (original, plain) (#985) * new icon: solidity (original, plain) * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: unrealengine (original, original-wordmark, plain, plain-wordmark) (#939) * added unrealengine icons * Changed viewbox size and optimized with inkscape * Changed names and removed horizontal wordmark versions * optimized with https://www.svgviewer.dev/ * added unrealengine to devicon.json * fix #346 * Removed white logos, and renamed the other ones * Changed color to #000000 and removed reference to deleted icons * centered logo in viewbox * optimized icon with svgviewer.dev * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Apply suggestions from code review * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: polygon (plain, original) (#989) * Added Discord.js Icons * Oops! * Forgot to add aliases. Co-authored-by: David Leal <halfpacho@gmail.com> * Change original wordmark to real SVG * Add plain-wordmark * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Apply suggestions from code review * Fixed wordmark * Create polygon-plain.svg * Update polygon-plain.svg * Update polygon-plain.svg * Create polygon-original-wordmark.svg * Delete polygon-original-wordmark.svg * Rename polygon-plain.svg to polygon-original.svg * Create polygon-plain.svg * Update polygon-plain.svg * Update polygon-plain.svg * Update and fix devicon.json * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Update icons/discordjs/discordjs-original-wordmark.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Apply suggestions from code review * Update polygon-plain.svg * Update polygon-plain.svg Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Upgrade PR and Issue Templates (#986) * Update issue templates * Add pr templates * Update templates * Update pr templates * Update default pr template * Clarify pr closing statement * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> * Update .github/PULL_REQUEST_TEMPLATE/new_feature.md Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> * New Feature: Add images for the wiki and edit links to point to it (#996) * Add wiki images * Update references to point to wiki * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> * Add import icomoon img Co-authored-by: David Leal <halfpacho@gmail.com> * New Feature: Small fixes to the templates and wiki image (#1005) * Small fixes for the templates and forms * Crop issue form image * Make checkbox mandatory * new icon: maya (original, original-wordmark, plain, plain-wordmark) (#1008) * new icon: maya (original, original-wordmark, plain, plain-wordmark) * add empty new line on svg files. Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: xcode (original, plain) (#1010) Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: selenium (original) (#1011) * new icon: selenium (original) * add empty new line on svg file. * remove duplicated closing tag. Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: pytorch (original, original-wordmark, plain-wordmark) (#1013) * new icon: pytorch (original, original-wordmark, plain, plain-wordmark) * add empty new line on svg files. Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: xamarin (original, original-wordmark) (#1014) * new icon: xamarin (original, original-wordmark) * Fix default color. * Update devicon.json Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: ifttt (original) (#1012) * new icon: ifttt (original) * add empty new line on svg file. Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: hugo (original, original-wordmark, plain, plain-wordmark) (#1015) * new icon: hugo (original, original-wordmark, plain, plain-wordmark) * Add hugo prefix on SVG files. Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: grafana (original, original-wordmark) (#1017) * new icon: grafana (original, original-wordmark) * Add grafana prefix on SVG files. Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: ansible (original, original-wordmark, plain, plain-wordmark) (#1019) Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: shotgrid (original, original-wordmark, plain) (#1020) * new icon: shotgrid (original, original-wordmark, plain) * add autodesk tag. Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: androidstudio (original, original-wordmark, plain, plain-wordmark) (#1021) * new icon: androidstudio (original, original-wordmark, plain, plain-wordmark) * remove useless new lines. Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: eslint (original, original-wordmark) (#1022) Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: latex (original) (#1023) * new icon: latex (original) * Fix typo in latex svg file name. Co-authored-by: David Leal <halfpacho@gmail.com> * ui enhancements for color picker and report abuse (#972, #943) (#1024) * Shorten instruction for size adjustment * New Feature: Add an Issue `in-develop` labeler and functions to close these issues (#990) * Working on labeler * Add in_develop_labeler * Build bot can close issues based on labels * Test mode for build * Fixed errors in labeler_bot * Update build-bot * Update .github/scripts/icomoon_build.py Co-authored-by: David Leal <halfpacho@gmail.com> * Remove test url Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> * new icon: Vuetify (original, line, plain) (#1033) * new icon: Vuetify ( original , plane , line) * new icon: Vuetify ( original , plain, line) * Revert "new icon: Vuetify ( original , plain, line)" This reverts commit fcff629. * icon: Vuetify svg, devicon.json updated * Vuetify .json updated * Vuetify versions updated in .json * Remove two S letters from text in SVG (#1038) * Update Discord Icon in Website * new icon: Vuetify ( original , plane , line) * new icon: Vuetify ( original , plain, line) * Revert "new icon: Vuetify ( original , plain, line)" This reverts commit fcff629. * icon: Vuetify svg, devicon.json updated * Vuetify .json updated * Vuetify versions updated in .json * buttonLink discord logo updated with primary color Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: openal (original, plain) (#1041) * new icon: openal (original, plain) * update icon: openal (original, plain) * new icon: sdl (original, plain) (#1043) * new icon: sdl (original, plain) * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Update icons/sdl/sdl-original.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Update icons/sdl/sdl-plain.svg Co-authored-by: David Leal <halfpacho@gmail.com> * Fix indentation and comma errors Co-authored-by: David Leal <halfpacho@gmail.com> * new icon: dropwizard (original, plain) (#906) * dropwizard icon added * Update dropwizard-original.svg * Update devicon.json * Update icons/dropwizard/dropwizard-original.svg Co-authored-by: David Leal <halfpacho@gmail.com> * plain version for dropwizard icon added * dropwizard-hat.eps --> dropwizard.eps * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Update dropwizard-original.svg * Update dropwizard-plain.svg Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: rect (original, plain) (#1051) * added rect icon * united plain rect svg paths * resized rect icons * changed rect icon kind from simplified to full Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: fedora (original, plain) (#1047) * Add fedora icons (optimized SVG files using SVGO) * Update devicon.json: add fedora icon data * Fix Fedora icon resolution * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> * Update fedora-original.svg * Update fedora-plain.svg * Update fedora-original.svg * Update fedora-plain.svg * Update fedora-original.svg * Update fedora-plain.svg * Update devicon.json Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Co-authored-by: David Leal <halfpacho@gmail.com> * Update the `check-bot` (#970) * Add check for strokes in check-bot * Add check for svg file name * Update gulpfile to remove x and y of svg elem * Revert name changes to err file * check-bot now check devicon object as well * Fixed minor bugs * Improve logging in check_icon Co-authored-by: David Leal <halfpacho@gmail.com> * Changed to select all rather before take a pic (#1058) * Fix the peek bot cmd line args (#1059) * Fix check icon not running for update icon pr (#1060) * Fix invalid function name (#1063) * update icon: confluence (original, original-wordmark) (#1045) * Update Confluence icons - as requested in #998 * Fix Confluence icons * Update viewbox dimensions * Resize icons properly * update icon: bitbucket (original, original-wordmark) (#1044) * Update Bitbucket icons * Fix Bitbucket icons * Update viewbox dimensions * Resize icons properly * new icon: bamboo (original, original-wordmark) (#1061) * Add Bamboo icons * Resize icons properly * new icon: terraform (original, original-wordmark, plain, plain-wordmark) (#1064) * Add Terraform icons * Resize icons accordingly * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> * update icon: jira (original, original-wordmark, plain, plain-wordmark) (#1062) * Update Jira icons * Update devicon.json to include tags for Confluence and Bitbucket * Resize icons properly * Replace plain icons * Missed one part with different color * Add fix for bad zip file and logging for build (#1069) * new icon: gentoo (plain, plain-wordmark) (#1075) * Add gentoo icons * Update devicon.json Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * new icon: webflow (plain, original) (#1070) * adding webflow Icon adding webflow icons and editing devicon.json small extra change on devicon.json: formatted json * Updating svg's to fill requirements * removing unnecessary tag * Removing webflow-original and replacing with plain, also removed plain from devicon.json * Updated Icon removing clip path and adding all in one path instead * new icon: opensuse (original, original-wordmark, plain, plain-wordmark) (#1076) * Add opensuse icons * Rename icons to include technology name * Build preparation for release v2.15.0 (#1079) * Remove outdated dropwized.eps * Built new icons, icomoon.json and devicon.css (#1078) Co-authored-by: Thomas-Boi <Thomas-Boi@users.noreply.github.com> * bump npm version to v2.15.0” * Add log.txt to gitignore * bump npm version to v2.15.0” Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Thomas-Boi <Thomas-Boi@users.noreply.github.com> Co-authored-by: Edward Jiwook Kim <kimjiwook0129@gmail.com> Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com> Co-authored-by: Patrik Wehrli <patrik.wehrli@terreactive.ch> Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com> Co-authored-by: Anshumaan Kumar Prasad <75872316+amino19@users.noreply.github.com> Co-authored-by: Max Petts <maxpetts9@gmail.com> Co-authored-by: Malte Jürgens <maltejur@dismail.de> Co-authored-by: Mazzya <41023812+Mazzya@users.noreply.github.com> Co-authored-by: Ozan Uslan <54141068+ozanuslan@users.noreply.github.com> Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com> Co-authored-by: Ethan <66741050+EthanDevelops@users.noreply.github.com> Co-authored-by: Ben Souchet <benjamin.souchet@gmail.com> Co-authored-by: Vikash2806 <vikashrajendran2806@gmail.com> Co-authored-by: dbaser <63173073+presentformyfriends@users.noreply.github.com> Co-authored-by: M Pater <mpater@tradosoft.com> Co-authored-by: RedCubeDev <61469501+RedCubeDev-ByteSpace@users.noreply.github.com> Co-authored-by: Rubens dos Santos <64743047+kaetaen@users.noreply.github.com> Co-authored-by: Justin Alex Paramanandan <1155821+jusuchin85@users.noreply.github.com> Co-authored-by: Jorch C <jacortez_94@hotmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Thomas-Boi <Thomas-Boi@users.noreply.github.com>
New feature section
Double check these details before you open a PR
This PR adds/fixes
Check-bot
:peek-bot
x
andy
in thesvg
and will not give warning for itdevicon.json
entry check frompeek-bot
tocheck-bot
gulp-task
x
andy
attributes of thesvg
element. This correspond with the abovecheck-bot
ignoringx
andy
peek-bot
:devicon.json
entry checkNotes
This changes the name of the
check_svgs
workflow and updates thepost_check_svgs_comment
yaml. Thus, the workflow won't work properly until the PR is merged intomaster
. I'll open this as the last thing before a release.I tested the workflow locally on my computer and in my fork. You can test it as well by running
python ./.github/scripts/check_icon_pr.py "new icon: your-testing-icon (original, plain)" ./icons ./devicon.json
in the project's root folder. Just modify the SVGs pointed to byyour-testing-icon
(say,react
) and check theerr_messages.txt
. Also try modifying thedevicon.json
(like removing thealiases
or adding an invalid versioncolored
) and see the error.