Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for non-void command handlers in duck typing #69

Closed
kzu opened this issue Nov 17, 2022 · 0 comments
Closed

Fix support for non-void command handlers in duck typing #69

kzu opened this issue Nov 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Nov 17, 2022

Due to the way we currently lookup for compatible types, we only consider IExecutableCommandHandler<> generic
type, leaving out all non-void ones.

Also, if the services are not registered with all interfaces (i.e. an ICommandHandler<T> only being registered for
that interface), the existing code will not find a compatible service and fail to duck-type.

We should relax that requirement since we only require the specific handler interface to be registered for all other
functionality (including CanExecute/CanHandle.
@kzu kzu added the enhancement New feature or request label Nov 17, 2022
@kzu kzu closed this as completed in c21624d Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kzu