Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow mappers to map to same type #80

Closed
kzu opened this issue Nov 19, 2022 · 0 comments
Closed

Don't allow mappers to map to same type #80

kzu opened this issue Nov 19, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kzu
Copy link
Member

kzu commented Nov 19, 2022

If the mapper has a bug and (say) maps a type to the same type,
we'd currently cause a stack overflow exception, since we'd map,
then attempt to execute again, fail to find a handler and map again
and so on.

We should shield from this situation and never allow self-mapping
of types.

@kzu kzu added the bug Something isn't working label Nov 19, 2022
@kzu kzu closed this as completed in a65561d Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant