Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply factory method defaults to TableRepository/TablePartition constructors #13

Closed
kzu opened this issue May 25, 2021 · 0 comments
Closed
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented May 25, 2021

When using the generic implementations via DI as follows:

 services.AddScoped(typeof(ITableRepository<>), typeof(TableRepository<>));
 services.AddScoped(typeof(ITablePartition<>), typeof(TablePartition<>));

The constructors would receive null values for things like the table name or partition key.
We should instead apply the same default value behavior we have in the corresponding
factory methods TableRepository.Create<T> and TablePartition<T> for consistency.

Back this issue
Back this issue

@kzu kzu added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 25, 2021
@kzu kzu closed this as completed in dd7bf5e May 26, 2021
@devlooped devlooped locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant