Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is working for .NET Core 3.1 ? #1

Closed
ignatandrei opened this issue Oct 5, 2020 · 6 comments
Closed

It is working for .NET Core 3.1 ? #1

ignatandrei opened this issue Oct 5, 2020 · 6 comments

Comments

@ignatandrei
Copy link

just asking if it is working for .NET Core 3.1
( I can reference the nuget ... - but it does not compile
Console.WriteLine(ThisAssembly.Info.Configuration);

@kzu
Copy link
Member

kzu commented Oct 5, 2020

Nope, this uses Roslyn source generators, which is a feature included in .net5 SDK and VS 16.8 previews

@kzu
Copy link
Member

kzu commented Oct 5, 2020

The next release will check this via targets so it's less surprising that it doesn't work

@kzu kzu closed this as completed Oct 5, 2020
@kzu kzu reopened this Oct 5, 2020
@kzu
Copy link
Member

kzu commented Oct 5, 2020

Hm... this check should already be shipping in the latest 1.0.0-alpha release. Are you not seeing that build error automatically when using .NET Core 3.1?

@ignatandrei
Copy link
Author

ignatandrei commented Oct 5, 2020

1>CSC : warning CS8032: An instance of analyzer ThisAssembly.AssemblyInfoGenerator cannot be created from C:\Users\aignat.nuget\packages\thisassembly.assemblyinfo\0.10.6\analyzers\netstandard2.0\ThisAssembly.AssemblyInfo.dll : Could not load file or assembly 'Microsoft.CodeAnalysis, Version=3.8.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified..

I have added reference to
PackageReference Include="Microsoft.CodeAnalysis" Version="3.8.0-3.final" /
PackageReference Include="ThisAssembly.AssemblyInfo" Version="0.10.6" /

But it gives the same error

@kzu
Copy link
Member

kzu commented Oct 6, 2020

Old version. Use ThisAssembly.* Version 1.0.0-alpha plz. The one you're referencing isn't even listed anymore :)

@ignatandrei
Copy link
Author

Now the error is more explicit 👍

ThisAssembly requires MSBuild 16.8+ or .NET SDK 5.0+.

Waiting for .NET 5 in one month or so ;-)
Thanks

@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants