Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThisAssembly.Git should add comment when properties are empty #179

Closed
kzu opened this issue Jan 28, 2023 · 1 comment
Closed

ThisAssembly.Git should add comment when properties are empty #179

kzu opened this issue Jan 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Jan 28, 2023

Since it's expected for most Git properties to be empty in design-time builds (and therefore, intellisense in the IDE), we should make it very obvious that this is not a failure on the package part, but something expected.

Perhaps the code comment on the generated constant should clarify this situation.
@kzu kzu added the enhancement New feature or request label Jan 28, 2023
@kzu
Copy link
Member Author

kzu commented Feb 4, 2023

Fixed now

@kzu kzu closed this as completed Feb 4, 2023
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kzu