Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LangVersion detection now that C# 9.0 is stable #26

Closed
kzu opened this issue Dec 15, 2020 · 0 comments
Closed

Improve LangVersion detection now that C# 9.0 is stable #26

kzu opened this issue Dec 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Dec 15, 2020

We currently force Preview as the lang version in our Prerequisites package/dependency. This is now unnecessary since C# 9.0 is stable now.

But we now need to detect the whole range of valid values for the LangVersion property that users might configure, as documented in https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/langversion-compiler-option.

We should check for C# 9.0+ explicitly (which includes latest, latestmajor and preview values) instead.
@kzu kzu added the enhancement New feature or request label Dec 15, 2020
@kzu kzu closed this as completed in 8e66ac4 Dec 15, 2020
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kzu