Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the C# language check a warning instead of an error #51

Closed
kzu opened this issue Mar 16, 2021 · 0 comments
Closed

Make the C# language check a warning instead of an error #51

kzu opened this issue Mar 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kzu
Copy link
Member

kzu commented Mar 16, 2021

Currently we report an error (both on BeforeCompile and CoreCompile) when we detect the project language isn't C# 9.0+.

This breaks a few IDE experiences since right after package installation, all design-time builds and real builds are effectively broken, which isn't a great uex.

By making it a warning instead, we give the user the chance to build, see it, perhaps attempt to type ThisAssembly and see that nothing happens, and then cleanly uninstall the package.

@kzu kzu added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 16, 2021
@kzu kzu closed this as completed in a2ad738 Mar 16, 2021
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant