Setters on deep mocks no longer work after updating to 4.14.6 from old version

[vruss]

I've noticed after upgrade from an older version of Moq to the latest that setters on deep mocks no longer work. It's a bit of an annoyance to fix 100s of test cases with this issue.

Interfaces

public interface IFoo
{
	int Property { get; set; }
}

public interface IBar
{
	IFoo Foo { get; set; }
}

Dosen't work

var bar = Mock.Of<IBar>(x => x.Foo.Property == 123);
Assert.AreEqual(123, bar.Foo.Property);

bar.Foo.Property = 321;
Assert.AreEqual(321, bar.Foo.Property); // Expected:<321>. Actual:<123>.

Works

var bar = Mock.Of<IBar>(x => x.Foo == Mock.Of<IFoo>(y => y.Property == 123));
Assert.AreEqual(123, bar.Foo.Property);

bar.Foo.Property = 321;
Assert.AreEqual(321, bar.Foo.Property);

[vruss]

Is this related to #1039?

[vruss]

Issue still present in 4.14.6

[stakx]

Is this related to #1039?

I don't think so. #1039 targeted non-overridable / non-interceptable properties. In your case, we are looking at overridable properties. I'll look into it.

[stakx]

This stopped working with version 4.14.0; more precisely, with cb6b71a. Thanks for reporting, this should be fixed. For the time being, I'd suggest you stay with version 4.13.1.

[vruss]

Thank you for fixing it so quickly!
@stakx any chance of this fix being included in an earlier 4.14.7 release?

[stakx]

any chance of this fix being included in an earlier 4.14.7 release

I suppose I could do that, yes.

[vruss]

I suppose I could do that, yes.

That would be so great!

[stakx]

@vruss, I've pushed a hotfix release version 4.14.7 to NuGet. It should become available shortly.