Does SetupAllProperties actually create any setups, or does it not?

[stakx]

Using Moq 4.9.0, given this:

public interface T
{
    T P { get; }
}

var mock = new Mock<T>();
mock.SetupAllProperties();

mock.Verify(m => m.P, Times.Once) will produce this error message:

Expected invocation on the mock once, but was 0 times: m => m.P
No setups configured.
No invocations performed.

mock.VerifyAll() will produce a contradictory error message:

The following setups on mock 'Mock<T:00000001>' were not matched:
T m => m.P

One error message says that there are no setups, while the other says that there is a setup. Which one is (or should be) correct?

[stakx]

In my opinion, mock.Verify(…) has it right: SetupAllProperties should not create any setups (meaning that VerifyAll should succeed).

Despite its name (which includes the word Setup), the intent behind SetupAllProperties is to conveniently "auto-implement" all properties such that they remember the values they're being set to.

VerifyAll is currently quite useless when a prior call to SetupAllProperties was made, because it then requires that each and every property accessor be invoked. The more properties a mocked type has, the more unlikely it becomes that someone is going to do just that. Therefore, it would probably be more useful in practice for VerifyAll to ignore properties "set up" by SetupAllProperties.

I'd love to get some input. What do others think about this?

[kzu]

Absolutely, you got it right @stakx: SetupAllProperties is just a way to get useful stubs.

[stakx]

Great, thanks. I'll then probably change the error messages & VerifyAll implementation so this works more seamlessly.