Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add parameter to struct for pushing block request for stopping scaling #18

Open
benjivesterby opened this issue Mar 25, 2023 · 1 comment
Assignees
Labels
research Research and Development

Comments

@benjivesterby
Copy link
Member

This should allow a caller to set the channel and then push to the channel to stop scaling and otherwise allow scaling. This will likely require a routine middle layer for translating a push to a stop to keep the scaler working normally.

@benjivesterby benjivesterby added the research Research and Development label Mar 29, 2023
@benjivesterby benjivesterby self-assigned this Mar 29, 2023
@benjivesterby
Copy link
Member Author

I'm not sure how I feel about this one. I'm going to test out the new scaling duration and max routine stuff before moving onto this.

The idea here was to allow an external user to push events over a channel to stop the scaling of go routines. This would allow for a user monitoring memory or cpu usage to halt scaling when exceeding some limit. It adds quite a bit of complexity as well as an additional backend goroutine and a select case with potential performance impact.

If the new additions for tuning are not sufficient then this may be necessary but for now I'm going to hold off on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research Research and Development
Projects
None yet
Development

No branches or pull requests

1 participant