From ac2efa9bf52a67f015d53d7a825b9cc0e9d5e399 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nils=20Neuh=C3=A4usel?= <n.neuhaeusel@gmail.com>
Date: Sat, 1 Apr 2023 12:00:09 +0200
Subject: [PATCH] Simple fixes

---
 .github/workflows/maven-build-test.yml               |  2 +-
 .../src/main/resources/template-set.xml              | 12 ------------
 .../devonfw/cobigen/retriever/ArtifactRetriever.java |  2 +-
 .../cobigen/retriever/settings/MavenSettings.java    |  3 ++-
 .../to/model/MavenSettingsActiveProfilesModel.java   |  2 +-
 .../unittest/SearchResponseFactoryTest.java          |  1 -
 6 files changed, 5 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/maven-build-test.yml b/.github/workflows/maven-build-test.yml
index 97a97477cf..338be07030 100644
--- a/.github/workflows/maven-build-test.yml
+++ b/.github/workflows/maven-build-test.yml
@@ -19,7 +19,7 @@ on:
       - '**.asciidoc'
 
 env:
-  # if continuously builds exiting ramdomy, possibly add again -Djansi.force=true -Djansi.passthrough=true
+  # if continuously builds exiting randomly, possibly add again -Djansi.force=true -Djansi.passthrough=true
   MVN_BATCH_MODE: '-B -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn'
   # fixing random connection reset of maven downloads as proposed here: https://github.com/actions/virtual-environments/issues/2715#issuecomment-797388909
   MVN_HTTP_OPTIMIZATION: '-Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120'
diff --git a/cobigen-templates/crud-java-server-app/src/main/resources/template-set.xml b/cobigen-templates/crud-java-server-app/src/main/resources/template-set.xml
index e478d3fe65..3f30e3a879 100644
--- a/cobigen-templates/crud-java-server-app/src/main/resources/template-set.xml
+++ b/cobigen-templates/crud-java-server-app/src/main/resources/template-set.xml
@@ -62,12 +62,6 @@
     <tc:increment name="ctos" description="CTO's">
       <tc:templateRef ref="${variables.entityName}Cto.java" />
     </tc:increment>
-    <!-- <increment name="logic_impl" description="CRUD logic (all in one)">
-      <templateRef ref="AbstractBeanMapperSupport.java"/>
-      <templateRef ref="AbstractComponentFacade.java"/>
-      <templateRef ref="${variables.component#cap_first}Impl.java"/>
-      <templateRef ref="${variables.component#cap_first}.java"/>
-    </increment>-->
     <tc:increment name="dataaccess_infrastructure" description="Entity infrastructure">
       <tc:templateRef ref="ApplicationPersistenceEntity.java" />
       <tc:templateRef ref="ApplicationEntity.java" />
@@ -86,12 +80,6 @@
       <tc:templateRef ref="${variables.component#cap_first}RestServiceImplCtos.java" />
       <tc:templateRef ref="${variables.component#cap_first}RestServiceCtos.java" />
     </tc:increment>
-    <!-- <increment name="soap_service_impl" description="CRUD SOAP services">
-      <templateRef ref="ServiceConfig.java"/>
-      <templateRef ref="WebApplicationContextLocator.java"/>
-      <templateRef ref="${variables.component#cap_first}SoapService.java"/>
-      <templateRef ref="${variables.component#cap_first}SoapServiceImpl.java"/>
-    </increment>-->
   </tc:increments>
 </tc:templatesConfiguration>
 </tns:templateSetConfiguration>
\ No newline at end of file
diff --git a/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/ArtifactRetriever.java b/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/ArtifactRetriever.java
index ab31734285..170d6ed1b7 100644
--- a/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/ArtifactRetriever.java
+++ b/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/ArtifactRetriever.java
@@ -60,7 +60,7 @@ public static List<String> retrieveTemplateSetJarDownloadURLs(List<String> group
   /**
    * Retrieves a list of maven artifact download URLs
    *
-   * @param groupIdsList grouIds for template-sets
+   * @param groupIdsList groupIds for template-sets
    * @param mavenSettings string of maven's settings.xml
    * @return list of maven artifact download URLs
    *
diff --git a/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/settings/MavenSettings.java b/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/settings/MavenSettings.java
index ae41f85fda..38bc9650e2 100644
--- a/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/settings/MavenSettings.java
+++ b/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/settings/MavenSettings.java
@@ -74,7 +74,8 @@ public static MavenSettingsProxyModel determineActiveProxy(MavenSettingsModel mo
   }
 
   /**
-   * Maps parts of maven's settings.xml to a Java class Mapping includes: settings-, profiles-, profile-, repository-,
+   * Maps parts of maven's settings.xml to a Java class.
+   * Mapping includes: settings-, profiles-, profile-, repository-,
    * repositories-, servers-, and server-elements
    *
    * @param mavenSettings string of maven's settings.xml
diff --git a/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/settings/to/model/MavenSettingsActiveProfilesModel.java b/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/settings/to/model/MavenSettingsActiveProfilesModel.java
index 01f7630803..a96864eb0a 100644
--- a/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/settings/to/model/MavenSettingsActiveProfilesModel.java
+++ b/cobigen/core-artifact-retriever/src/main/java/com/devonfw/cobigen/retriever/settings/to/model/MavenSettingsActiveProfilesModel.java
@@ -5,7 +5,7 @@
 import jakarta.xml.bind.annotation.XmlElement;
 
 /**
- * Class, which represents the activeProfiles element of maven's setting.xml
+ * Class, which represents the activeProfiles element of maven's settings.xml
  *
  */
 public class MavenSettingsActiveProfilesModel {
diff --git a/cobigen/core-artifact-retriever/src/test/java/com/devonfw/cobigen/retriever/unittest/SearchResponseFactoryTest.java b/cobigen/core-artifact-retriever/src/test/java/com/devonfw/cobigen/retriever/unittest/SearchResponseFactoryTest.java
index 6bdd15fad7..8e1857de0d 100644
--- a/cobigen/core-artifact-retriever/src/test/java/com/devonfw/cobigen/retriever/unittest/SearchResponseFactoryTest.java
+++ b/cobigen/core-artifact-retriever/src/test/java/com/devonfw/cobigen/retriever/unittest/SearchResponseFactoryTest.java
@@ -239,7 +239,6 @@ public void testNexus3EmptyDownloadLinksAfterSearchRequestCancelsAndReturnsEmpty
 
   /**
    * Tests if an empty list gets returned if the search request received an empty json string as a response
-   *
    */
   @Test
   public void testSearchRequestWithEmptyJsonResponseReturnsEmptyList() {