Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1391: avoid files like dependencies.json are considered as version #1392

Merged
merged 2 commits into from
Nov 12, 2024
Merged

#1391: avoid files like dependencies.json are considered as version #1392

merged 2 commits into from
Nov 12, 2024

Conversation

hohwille
Copy link
Member

fixes #1391
filter for directories when searching/resolving versions.

@hohwille hohwille added this to the release:2024.11.001 milestone Nov 11, 2024
@github-actions github-actions bot added bash related to bash shell or scripts scripts related to shell scripts (bash and CMD) labels Nov 11, 2024
@hohwille hohwille self-assigned this Nov 11, 2024
@hohwille hohwille added enhancement New feature or request blocker severe bug that blocks users in their daily work and has to be fixed asap labels Nov 11, 2024
jan-vcapgemini
jan-vcapgemini approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for increasing the robustness of the script by checking directories only.

@hohwille hohwille merged commit 402fbad into devonfw:master Nov 12, 2024
4 checks passed
@hohwille
Copy link
Member Author

I considered this as a kind of approval and merged this PR/bugfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

Labels
bash related to bash shell or scripts blocker severe bug that blocks users in their daily work and has to be fixed asap enhancement New feature or request scripts related to shell scripts (bash and CMD)
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.11.001
Development

Successfully merging this pull request may close these issues.

dependencies.json not supported - tomcat not working anymore
2 participants
@hohwille @jan-vcapgemini