Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_bucket namespace-env and namespace-org should be parametrized #13

Open
marcoreni opened this issue Jun 5, 2018 · 2 comments
Open

Comments

@marcoreni
Copy link

I think both variables should be parametrized, otherwise we may obtain an invalid bucket name if not specifying an organization (i.e. -<env>-<bucketname>)

@marcoreni
Copy link
Author

marcoreni commented Jun 5, 2018

Also, bucket name and Name tag should yield the same value.

@snemetz
Copy link
Member

snemetz commented Jun 5, 2018

You're right the S3 log bucket section needs some work.
Unlike most things in AWS, S3 is a global namespace. That is why I required the namespaces for it. Otherwise you're likely to run into conflicts with yourself or another AWS customer.

The logging part was never finished. You'll see it doesn't get added to the LB.
Yes. bucket name and tag should be the same.

Haven't been using logging where I am. So not sure when I can work on this. Would happily accept a PR though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants