Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[potential issue] several alerts displaying problem #2

Closed
piechart opened this issue Aug 13, 2020 · 3 comments · Fixed by #4
Closed

[potential issue] several alerts displaying problem #2

piechart opened this issue Aug 13, 2020 · 3 comments · Fixed by #4
Assignees
Labels
bug Something isn't working

Comments

@piechart
Copy link

piechart commented Aug 13, 2020

When a new alert must be presented as a result of selecting any action button on a previous one, it becomes impossible because action handler executes before AlertViewController is dismissed.
Warning: Attempt to present <UIAlertController: 0x7fb07a1bba00> on <...IssueDetailViewController: 0x7fb07a883400> which is already presenting (null)
If action.handler was executed in AlertViewController.completionHandler that would solve the issue. Not sure if this sequence of action.handler execution will fit all the cases to update current logic with this one

@devpolant devpolant added the bug Something isn't working label Aug 13, 2020
@devpolant
Copy link
Owner

Actually, as far as I remember, the similar issue occurred with native UIAlertController too.
I think it can be fixed by dismissing alert manually instead of automatic dismiss. I will try to push updates in the near few days. Btw, if you have any proposal feel free to open pull request :)

@devpolant
Copy link
Owner

@piechart Version 1.1.0 released. It contains fix for this issue.

@devpolant
Copy link
Owner

@piechart Please take a look at this paragraph in readme file https://github.com/AntonPoltoratskyi/NativeUI#edge-cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants