From 4534d203617ec6afacca90832e5c96b506d4134a Mon Sep 17 00:00:00 2001 From: Russell Centanni Date: Tue, 7 Nov 2023 13:41:51 -0500 Subject: [PATCH] fix: only upload pull secret credentials for kaniko and in cluster buildkit builds Fixes #2729 Fixes ENG-2185 Signed-off-by: Russell Centanni --- pkg/devspace/build/build.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/pkg/devspace/build/build.go b/pkg/devspace/build/build.go index 3d0e215da4..c3ba7a2d9b 100644 --- a/pkg/devspace/build/build.go +++ b/pkg/devspace/build/build.go @@ -1,9 +1,10 @@ package build import ( + "strings" + dockerclient "github.com/loft-sh/devspace/pkg/devspace/docker" "github.com/loft-sh/devspace/pkg/devspace/pullsecrets" - "strings" "github.com/loft-sh/devspace/pkg/devspace/build/builder" "github.com/loft-sh/devspace/pkg/devspace/build/types" @@ -104,11 +105,6 @@ func (c *controller) Build(ctx devspacecontext.Context, images []string, options ctx.Log().Errorf("error ensuring pull secret for registry %s: %v", registryURL, err) } } - - err = pullsecrets.NewClient().EnsurePullSecret(ctx, dockerClient, ctx.KubeClient().Namespace(), registryURL) - if err != nil { - ctx.Log().Errorf("error ensuring pull secret for registry %s: %v", registryURL, err) - } } }