-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use options
field for Kaniko from Docker (in fallback case)
#1376
Comments
@saruman9 thanks for creating this issue! They actually should get copied by default, could you provide a sample devspace.yaml where this is not the case? |
My fault: I don't test the case without the version: v1beta9
images:
default:
image: default
build:
docker:
options:
target: base
buildArgs:
TEST: test
kaniko:
snapshotMode: redo
args:
- --use-new-run It's normal, that Kaniko don't run with |
@saruman9 Ah I see, that makes sense yes, we can implement that. |
@saruman9 After some consideration, I don't think we should do this. In the case where no |
After some days of testing I agree with you, user should explicitly set all settings for Kaniko (include Thank you for reviewing my request. |
Is your feature request related to a problem?
Yes.
Options not inherited from
images.app.build.docker.options
when builder changed to Kaniko (as fallback for Docker).Which solution do you suggest?
Inherit options for Kaniko from Docker in fallback case.
Which alternative solutions exist?
Copy
images.app.build.docker.options
toimages.app.build.kaniko.options
./kind feature
The text was updated successfully, but these errors were encountered: