-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ui shows internal command when it maybe shouldn't #2923
Comments
What is your concern of showing the internal commands? The UI doesn't have any special permissions and it's hosted locally, so this is really scoped to the individual user. |
Hi. |
This would be a feature request, so we've updated that and will look back shortly. In the meantime a PR would be welcome. Thanks! |
I would give it a go at creating a PR. How should the internal commands be treated? devspace/ui/src/pages/commands/commands.tsx Line 103 in a633a2b
|
I am having some trouble seeing my changes locally. |
Hi. |
For ui development, try uncommenting this and opening it up on port 3000. |
@zerbitx Thanks for your help. |
What happened?
When I visit the commands page of the ui i can see and execute internal commands
What did you expect to happen instead?
I would expect internal commands to not appear at all or at least to not be executable
How can we reproduce the bug? (as minimally and precisely as possible)
Define an internal command and check the commands page
My devspace.yaml:
Local Environment:
Kubernetes Cluster:
Client Version: v1.31.0
Kustomize Version: v5.4.2
Server Version: v1.30.6+k3s1
Anything else we need to know?
The text was updated successfully, but these errors were encountered: