Skip to content
This repository has been archived by the owner on Jul 2, 2018. It is now read-only.

Is it possible to swift_seedname_prefix individually for each seed? #61

Open
acecilia opened this issue Jun 1, 2016 · 3 comments
Open

Comments

@acecilia
Copy link

acecilia commented Jun 1, 2016

This will allow to edit the source code of the project and make a pull request from your own project. (When using swift_seedname_prefix the names of the files are changed and pull request from the project is not possible, I think)

Thanks!

@devxoul
Copy link
Owner

devxoul commented Jun 2, 2016

@acecilia, Could you please provide me a detailed situation? I cannot understand why do you need that feature.

@acecilia
Copy link
Author

acecilia commented Jun 3, 2016

Sure.

You have two third party frameworks: A and B.
A and B has one common file name: commonFileName.swift
So in order to make them work, you set swift_seedname_prefix and the common files now has different names: A_commonFileName.swift and B_commonFileName.swift
If you now want to modify B_commonFileName.swift and make a pullRequest, it is not possible from your project because all the files in the framework changed to B_*.swift.

If swift_seedname_prefix could be applied per-framework you could:
Use swift_seedname_prefix with framework A, so the common file will be named A_commonFileName.swift
NOT use swift_seedname_prefix with framework B, so the common file will be named commonFileName.swift
And now you could modify commonFileName.swift in framework B and make a pullRequest from your own project.

Anyway, reading it now seems like too much work for such a feature, I was asking so maybe it was already implemented.

Thank you.

@devxoul
Copy link
Owner

devxoul commented Jun 4, 2016

Thank you for detailed explanation.

I think applying swift_seedname_prefix per-framework doesn't have any advantages. Making a pull request should be performed in separated project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants