From b447df7c8d3fb1c9bfe1b63d120e670f23679e05 Mon Sep 17 00:00:00 2001 From: Daniel Lipovetsky Date: Wed, 18 Jan 2023 12:21:22 -0800 Subject: [PATCH] fix: connector/google: Remove unused parameter from test helper function Reported by golangci-lint v1.50.1 The parameter was introduced in https://github.com/dexidp/dex/pull/2530/commits/87dc843e6752cb6cd36315e9efd43102c4025e2e#diff-f4e262eadea100c93616fa91cb230c785e624025a68deeab910e663f9e7356c8L28-L33, but became unused as of https://github.com/dexidp/dex/pull/2530/commits/7b19c536252d6c1fcdafa4c0097b12ef10f9f7d5#diff-f4e262eadea100c93616fa91cb230c785e624025a68deeab910e663f9e7356c8R27-R29 Signed-off-by: Daniel Lipovetsky --- connector/google/google_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/connector/google/google_test.go b/connector/google/google_test.go index bde12e0676..cf5977ab6a 100644 --- a/connector/google/google_test.go +++ b/connector/google/google_test.go @@ -46,7 +46,7 @@ func testSetup() *httptest.Server { return httptest.NewServer(mux) } -func newConnector(config *Config, serverURL string) (*googleConnector, error) { +func newConnector(config *Config) (*googleConnector, error) { log := logrus.New() conn, err := config.Open("id", log) if err != nil { @@ -155,7 +155,7 @@ func TestOpen(t *testing.T) { assert := assert.New(t) os.Setenv("GOOGLE_APPLICATION_CREDENTIALS", reference.adc) - conn, err := newConnector(reference.config, ts.URL) + conn, err := newConnector(reference.config) if reference.expectedErr == "" { assert.Nil(err) @@ -181,7 +181,7 @@ func TestGetGroups(t *testing.T) { RedirectURI: ts.URL + "/callback", Scopes: []string{"openid", "groups"}, AdminEmail: "admin@dexidp.com", - }, ts.URL) + }) assert.Nil(t, err) conn.adminSrv, err = admin.NewService(context.Background(), option.WithoutAuthentication(), option.WithEndpoint(ts.URL))