-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Azure AD roles claim #2108
Comments
The linked issue is slightly different in my opinion. We have similar claim mapping solutions in other providers. |
This is also needed for any large organization because groups claim in Azure-returned JWT has a character limit, so if a person is member of too many, then they won't all fit to the token. The recommended solution to this is to use roles. Relevant doc |
@sagikazarmark Do you know how we can proceed with this? |
Still open issue. Application Roles would be very useful. Groups can become unwieldy quick so using roles would be more "lean" for doing RBAC mapping vs groups. |
App registrations in Azure AD support custom application roles that are emitted as a
roles
claim in theid_token
.https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-add-app-roles-in-azure-ad-apps
Is your feature request related to a problem?
Roles is a nice alternative or complement to groups as explained in the linked document from Microsoft. It also doesn't need any permissions that require global admin consent, like
Directory.Read.All
.Describe the solution you'd like to see
I guess this would require a new custom claim in dex as it's not a standard claim?
Describe alternatives you've considered
N/A
Additional context
I added a comment in #1182 as well as another rational for custom claims mapping.
The text was updated successfully, but these errors were encountered: