-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenID Provider Configuration Information is stick to root path (/
)
#502
Comments
Thanks for the issue. We do need to address this. In addition we need to do thorough testing to make sure Dex behaves properly if running on a non-root path (we have not yet validated this will work). |
A big issue is the HTML templates. Many of the template us hard coded paths.[0] Consider either introducing a template function[1] to prepend a base path:
or just pass paths into the template manually. cc @xaka [0] https://github.com/coreos/dex/blob/33010e22c48485ec20b38c8b25aa6b69ece91bab/static/html/register.html#L35 |
@ericchiang |
Ah sorry. Will try to get a fix in tomorrow. Reopening. |
Another bug. Redirects are currently wrong and assume no one is trimming the path. For example [0] |
Awesome, it works for me either. Thanks a lot guys! |
@alon-argus apologies, we were having some issues with travis. |
From OpenID Connect specs:
OpenID Providers supporting Discovery MUST make a JSON document available at the path formed by concatenating the string /.well-known/openid-configuration to the Issuer.
I just tried to run dex-worker with these parameters:
/bin/dex-worker --listen=http://0.0.0.0:5556/auth --issuer=http://127.0.0.1:5556/auth ...
The dex-worker does do as expected and listens & serves the authentication endpoints under
/auth
path. However, apparently, the provider's configuration information (".well-known/openid-configuration" endpoint) is still located under the root path (That is, http://127.0.0.1:5556/.well-known/openid-configuration), and this violates the OpenID Connect clause that is quoted above.Thanks guys :)
The text was updated successfully, but these errors were encountered: