From 6de91403b3a7e65444851b0542a4ff37f97303ae Mon Sep 17 00:00:00 2001 From: Linwei Shang Date: Fri, 29 Mar 2024 09:41:10 -0400 Subject: [PATCH 1/3] try beta --- .github/workflows/examples.yml | 2 ++ examples/management_canister/tests/basic.bats | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/examples.yml b/.github/workflows/examples.yml index bb9dce1b4..39752fb93 100644 --- a/.github/workflows/examples.yml +++ b/.github/workflows/examples.yml @@ -92,6 +92,8 @@ jobs: - name: Install DFX uses: dfinity/setup-dfx@main + with: + dfx-version: "0.19.0-beta.1" - name: Install bitcoin if: ${{ matrix.project-name == 'management_canister' }} diff --git a/examples/management_canister/tests/basic.bats b/examples/management_canister/tests/basic.bats index c7ae752b2..708772de1 100644 --- a/examples/management_canister/tests/basic.bats +++ b/examples/management_canister/tests/basic.bats @@ -30,8 +30,9 @@ teardown() { # The bitcoin canister bundled with dfx 0.18.0 doesn't work with application replica # As a temporary remedy, we download a previous release. # TODO: remove when dfx fix, SDKTG-296 - wget -O ic-btc-canister.wasm.gz https://github.com/dfinity/bitcoin-canister/releases/download/release%2F2023-10-13/ic-btc-canister.wasm.gz - DFX_BITCOIN_WASM=ic-btc-canister.wasm.gz dfx start --clean --background --enable-bitcoin + # wget -O ic-btc-canister.wasm.gz https://github.com/dfinity/bitcoin-canister/releases/download/release%2F2023-10-13/ic-btc-canister.wasm.gz + # DFX_BITCOIN_WASM=ic-btc-canister.wasm.gz dfx start --clean --background --enable-bitcoin + dfx start --clean --background --enable-bitcoin dfx deploy run dfx canister call caller execute_bitcoin_methods From 7586cbdc4d443e81b0726b318b962be645f9dd78 Mon Sep 17 00:00:00 2001 From: Linwei Shang Date: Tue, 2 Apr 2024 12:17:50 -0400 Subject: [PATCH 2/3] remove with beta --- .github/workflows/examples.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/examples.yml b/.github/workflows/examples.yml index 39752fb93..bb9dce1b4 100644 --- a/.github/workflows/examples.yml +++ b/.github/workflows/examples.yml @@ -92,8 +92,6 @@ jobs: - name: Install DFX uses: dfinity/setup-dfx@main - with: - dfx-version: "0.19.0-beta.1" - name: Install bitcoin if: ${{ matrix.project-name == 'management_canister' }} From 640e2a6601aff9ac3a42d26c9e9027cc61f37a23 Mon Sep 17 00:00:00 2001 From: Linwei Shang Date: Tue, 2 Apr 2024 12:25:40 -0400 Subject: [PATCH 3/3] remove outdated comment --- examples/management_canister/tests/basic.bats | 5 ----- 1 file changed, 5 deletions(-) diff --git a/examples/management_canister/tests/basic.bats b/examples/management_canister/tests/basic.bats index 708772de1..8c51a7fa8 100644 --- a/examples/management_canister/tests/basic.bats +++ b/examples/management_canister/tests/basic.bats @@ -27,11 +27,6 @@ teardown() { @test "bitcoin methods succeed" { bitcoind -regtest -daemonwait - # The bitcoin canister bundled with dfx 0.18.0 doesn't work with application replica - # As a temporary remedy, we download a previous release. - # TODO: remove when dfx fix, SDKTG-296 - # wget -O ic-btc-canister.wasm.gz https://github.com/dfinity/bitcoin-canister/releases/download/release%2F2023-10-13/ic-btc-canister.wasm.gz - # DFX_BITCOIN_WASM=ic-btc-canister.wasm.gz dfx start --clean --background --enable-bitcoin dfx start --clean --background --enable-bitcoin dfx deploy